Issue 1508233003: Record OSThread::trace_id() instead of OSThread::id() in profile samples.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1508233003: Record OSThread::trace_id() instead of OSThread::id() in profile samples. (Closed)

Created:
5 years ago by rmacnak

Modified:
5 years ago

Reviewers:
Cutch, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Record OSThread::trace_id() instead of OSThread::id() in profile samples. The profiler only uses the thread id to check if two samples with the same timestamp belong to the same thread. Using trace_id() allows profile samples to be correctly grouped with timeline events. R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/dfa715727b0d0ff8743ce609c707537f94e7857b

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	runtime/vm/profiler.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

5 years ago (2015-12-10 17:46:46 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
dfa715727b0d0ff8743ce609c707537f94e7857b (presubmit successful).