Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: chrome/browser/resources/settings/settings_page/settings_section.js

Issue 1508233002: Settings Rewrite: Update comments on related to routing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/settings/settings_page/settings_animated_pages.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-section' shows a paper material themed section with a header 7 * 'settings-section' shows a paper material themed section with a header
8 * which shows its page title. 8 * which shows its page title.
9 * 9 *
10 * Example: 10 * Example:
11 * 11 *
12 * <settings-section page-title="[[pageTitle]]"> 12 * <settings-section page-title="[[pageTitle]]" section="privacy">
13 * <!-- Insert your section controls here --> 13 * <!-- Insert your section controls here -->
14 * </settings-section> 14 * </settings-section>
15 * 15 *
16 * @group Chrome Settings Elements 16 * @group Chrome Settings Elements
17 * @element settings-section 17 * @element settings-section
18 */ 18 */
19 Polymer({ 19 Polymer({
20 is: 'settings-section', 20 is: 'settings-section',
21 21
22 behaviors: [ 22 behaviors: [
23 Polymer.NeonAnimationRunnerBehavior, 23 Polymer.NeonAnimationRunnerBehavior,
24 ], 24 ],
25 25
26 properties: { 26 properties: {
27 /** 27 /**
28 * The current active route. 28 * The current active route.
29 */ 29 */
30 currentRoute: { 30 currentRoute: {
31 type: Object, 31 type: Object,
32 observer: 'currentRouteChanged_', 32 observer: 'currentRouteChanged_',
33 }, 33 },
34 34
35 /** 35 /**
36 * The section is expanded to a full-page view when this property matches 36 * The section is expanded to a full-page view when this property matches
37 * currentRoute.section. 37 * currentRoute.section.
38 *
39 * The section name must match the name specified in settings_router.js.
38 */ 40 */
39 section: { 41 section: {
40 type: String, 42 type: String,
41 }, 43 },
42 44
43 /** 45 /**
44 * Title for the page header and navigation menu. 46 * Title for the page header and navigation menu.
45 */ 47 */
46 pageTitle: String, 48 pageTitle: String,
47 49
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 {'top': oldRect.top + 'px', 'height': oldRect.height + 'px'}, 179 {'top': oldRect.top + 'px', 'height': oldRect.height + 'px'},
178 {'top': newRect.top + 'px', 'height': newRect.height + 'px'}, 180 {'top': newRect.top + 'px', 'height': newRect.height + 'px'},
179 ], this.timingFromConfig(config)); 181 ], this.timingFromConfig(config));
180 return this._effect; 182 return this._effect;
181 }, 183 },
182 184
183 complete: function(config) { 185 complete: function(config) {
184 config.node.classList.remove('neon-animating'); 186 config.node.classList.remove('neon-animating');
185 } 187 }
186 }); 188 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/settings/settings_page/settings_animated_pages.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698