Settings Rewrite: Update comments on related to routing.

Settings Rewrite: Update comments on related to routing.

Updates comments in:
 1) settings-animated-pages
 2) settings-section

BUG=425627
Committed: https://crrev.com/026b937897e105e2a54a96d19811cd039df26a8f
Cr-Commit-Position: refs/heads/master@{#364421}

[tommycli, 2015-12-08 23:08:03]

tommycli@chromium.org changed reviewers:
+ michaelpg@chromium.org

[tommycli, 2015-12-08 23:08:04]

michealpg: PTAL. Noticed some comments were out of date. This patch fixes that.

[tommycli, 2015-12-09 23:56:33]

michaelpg: ping

[michaelpg, 2015-12-10 00:23:45]

thanks for the ping, lgtm w/ an optional suggestion

https://codereview.chromium.org/1508233002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page/settings_animated_pages.js
(right):

https://codereview.chromium.org/1508233002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/settings_animated_pages.js:40:
*/
Could you consider adding the comment here instead? I usually look to these
comments to determine what a property does/how to use it.

https://codereview.chromium.org/1508233002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page/settings_section.js
(right):

https://codereview.chromium.org/1508233002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/settings_section.js:41: */
likewise

[tommycli, 2015-12-10 01:59:52]

michaelpg: Thanks! See if the new ones look better.

https://codereview.chromium.org/1508233002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page/settings_animated_pages.js
(right):

https://codereview.chromium.org/1508233002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/settings_animated_pages.js:40:
*/
On 2015/12/10 00:23:44, michaelpg wrote:
> Could you consider adding the comment here instead? I usually look to these
> comments to determine what a property does/how to use it.

Done.

https://codereview.chromium.org/1508233002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page/settings_section.js
(right):

https://codereview.chromium.org/1508233002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/settings_section.js:41: */
On 2015/12/10 00:23:45, michaelpg wrote:
> likewise

Done.

[michaelpg, 2015-12-10 03:23:27]

Cool, thanks! slgtm

[tommycli, 2015-12-10 18:15:59]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2015-12-10 18:15:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/1508233002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-12-10 18:17:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1508233002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1508233002/20001

[commit-bot: I haz the power, 2015-12-10 19:17:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-10 19:18:02]

Description was changed from

==========
Settings Rewrite: Update comments on related to routing.

Updates comments in:
 1) settings-animated-pages
 2) settings-section

BUG=425627
==========

to

==========
Settings Rewrite: Update comments on related to routing.

Updates comments in:
 1) settings-animated-pages
 2) settings-section

BUG=425627

Committed: https://crrev.com/026b937897e105e2a54a96d19811cd039df26a8f
Cr-Commit-Position: refs/heads/master@{#364421}
==========

[commit-bot: I haz the power, 2015-12-10 19:18:03]

Patchset 2 (id:??) landed as
https://crrev.com/026b937897e105e2a54a96d19811cd039df26a8f
Cr-Commit-Position: refs/heads/master@{#364421}