Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1508223006: no need for newlines in DM Errors (Closed)

Created:
5 years ago by mtklein_C
Modified:
5 years ago
Reviewers:
scroggo, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

no need for newlines in DM Errors This should fix some odd formatting problems in the logs, e.g. Note tally: 583x (skipped: Cannot convert to requested color type. ) 4x (--blacklist _ image decode 4bpp-pixeldata-cropped.bmp) ~~~> Note tally: 583x (skipped: Cannot convert to requested color type.) 4x (--blacklist _ image decode 4bpp-pixeldata-cropped.bmp) BUG=skia: Committed: https://skia.googlesource.com/skia/+/9b439153fc2a2ddca25de96fe2883cf67aebe3e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M dm/DMSrcSink.cpp View 12 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mtklein_C
5 years ago (2015-12-09 20:49:46 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1508223006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1508223006/1
5 years ago (2015-12-09 20:50:14 UTC) #4
scroggo
lgtm
5 years ago (2015-12-09 20:54:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1508223006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1508223006/1
5 years ago (2015-12-09 20:57:34 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-09 21:02:28 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9b439153fc2a2ddca25de96fe2883cf67aebe3e0

Powered by Google App Engine
This is Rietveld 408576698