Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1508203003: Move layout_constants.cc from c/b/ui/views/ to c/b/ui/ (Closed)

Created:
5 years ago by Evan Stade
Modified:
5 years ago
CC:
chromium-reviews, tfarina, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move layout_constants.cc from c/b/ui/views/ to c/b/ui/ so non-views files can use it. BUG=564340 Committed: https://crrev.com/d485dfe933e9a8f4164d5789457d7662502e7714 Cr-Commit-Position: refs/heads/master@{#363953}

Patch Set 1 #

Patch Set 2 : what is mus #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -301 lines) Patch
A + chrome/browser/ui/layout_constants.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/layout_constants.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/views/layout_constants.h View 1 chunk +0 lines, -129 lines 0 comments Download
D chrome/browser/ui/views/layout_constants.cc View 1 chunk +0 lines, -149 lines 0 comments Download
M chrome/browser/ui/views/location_bar/background_with_1_px_border.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/app_menu_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Evan Stade
5 years ago (2015-12-09 00:18:08 UTC) #3
Peter Kasting
RS LGTM
5 years ago (2015-12-09 01:04:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1508203003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1508203003/20001
5 years ago (2015-12-09 01:35:44 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-09 02:50:35 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-09 02:51:24 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d485dfe933e9a8f4164d5789457d7662502e7714
Cr-Commit-Position: refs/heads/master@{#363953}

Powered by Google App Engine
This is Rietveld 408576698