Issue 1508193002: Fixes for Chromium checkperms.py PRESUBMIT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1508193002: Fixes for Chromium checkperms.py PRESUBMIT (Closed)

Created:
5 years ago by Mark Mentovai

Modified:
5 years ago

Reviewers:
scottmg

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

Fixes for Chromium checkperms.py PRESUBMIT BUG=chromium:472900 R=scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/7efdc94f5982a1f9654c53fd4bf5663e5efa66ce

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+-2 lines, -0 lines)			Patch
M	doc/support/compat.sh	View	1 chunk	+0 lines, -2 lines	0 comments	Download
A	handler/win/z7_test.dll	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	snapshot/win/end_to_end_test.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Mark Mentovai

checkperms.py failed: *************** FAILED …/third_party/crashpad/crashpad/doc/support/compat.sh: Has shebang but not executable bit …/third_party/crashpad/crashpad/handler/win/z7_test.dll: Must have executable ...

5 years ago (2015-12-08 21:02:05 UTC) #2

Mark Mentovai

5 years ago (2015-12-08 21:24:59 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7efdc94f5982a1f9654c53fd4bf5663e5efa66ce (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages