Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1508183002: fixes #25094, type params in static methods shouldn't always be an error (Closed)

Created:
5 years ago by Jennifer Messerly
Modified:
5 years ago
Reviewers:
Leaf, Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fixes #25094, type params in static methods shouldn't always be an error R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/c985c599edc219a25525fc246e177301a6fd2c1b

Patch Set 1 #

Patch Set 2 : merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -4 lines) Patch
M pkg/analyzer/lib/src/generated/error.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 1 chunk +8 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
5 years ago (2015-12-08 21:00:44 UTC) #2
Leaf
lgtm
5 years ago (2015-12-08 21:17:19 UTC) #3
Jennifer Messerly
5 years ago (2015-12-08 22:08:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c985c599edc219a25525fc246e177301a6fd2c1b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698