src/api.cc - Issue 150813004: In-heap small typed arrays

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 150813004: In-heap small typed arrays (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: CR feedback Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 402598f40e3b9fc9ed5b8caad9855ea85f7d2d27..14270b79c617700231929d50f3b786507e17cf8d 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -6096,7 +6096,9 @@ i::Handle<i::JSTypedArray> NewTypedArray(

isolate->factory()->NewExternalArray(

static_cast<int>(length), array_type,

static_cast<uint8_t*>(buffer->backing_store()) + byte_offset);

- obj->set_elements(*elements);

+ i::Handle<i::Map> map =

+ i::JSObject::GetElementsTransitionMap(obj, elements_kind);

+ obj->set_map_and_elements(*map, *elements);

return obj;

}

« no previous file with comments | « src/accessors.cc ('k') | src/bootstrapper.cc » ('j') | src/hydrogen.cc » ('J')