src/objects-debug.cc - Issue 150813004: In-heap small typed arrays

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-debug.cc

Issue 150813004: In-heap small typed arrays (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: CR feedback + rebase Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-debug.cc

diff --git a/src/objects-debug.cc b/src/objects-debug.cc

index 31a59cbfb2b23a4490880c312eb4c39c1f1ba9c2..e22480c9bfab59ee12bea0061ff9619fead608b3 100644

--- a/src/objects-debug.cc

+++ b/src/objects-debug.cc

@@ -767,7 +767,8 @@ void JSArrayBufferView::JSArrayBufferViewVerify() {

CHECK(IsJSArrayBufferView());

JSObjectVerify();

VerifyPointer(buffer());

- CHECK(buffer()->IsJSArrayBuffer() || buffer()->IsUndefined());

+ CHECK(buffer()->IsJSArrayBuffer() || buffer()->IsUndefined()

+ || buffer() == Smi::FromInt(0));

VerifyPointer(byte_offset());

CHECK(byte_offset()->IsSmi() || byte_offset()->IsHeapNumber()

« src/objects.cc ('K') | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »