Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1445)

Unified Diff: mojo/edk/system/message_pipe_dispatcher.h

Issue 1508053003: Show the callstack that a nontransferable message pipe was first used if it's erroneously sent later (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove frame fix Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/edk/system/message_pipe_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/message_pipe_dispatcher.h
diff --git a/mojo/edk/system/message_pipe_dispatcher.h b/mojo/edk/system/message_pipe_dispatcher.h
index d70d3bcf5615959059257f590c7ab32ce0fdece9..976064d137cc03875734977e9ad7c91dd721a706 100644
--- a/mojo/edk/system/message_pipe_dispatcher.h
+++ b/mojo/edk/system/message_pipe_dispatcher.h
@@ -14,6 +14,12 @@
#include "mojo/edk/system/system_impl_export.h"
#include "mojo/public/cpp/system/macros.h"
+namespace base {
+namespace debug {
+class StackTrace;
+}
+}
+
namespace mojo {
namespace edk {
@@ -141,7 +147,7 @@ class MOJO_SYSTEM_IMPL_EXPORT MessagePipeDispatcher final
// consumed through MojoReadMessage yet.
MessageInTransitQueue message_queue_;
- // The following members are only used when transferable_ is false;
+ // The following members are only used when transferable_ is true;
// When sending MP, contains serialized message_queue_.
std::vector<char> serialized_message_queue_;
@@ -155,7 +161,7 @@ class MOJO_SYSTEM_IMPL_EXPORT MessagePipeDispatcher final
size_t serialized_message_fds_length_;
ScopedPlatformHandle serialized_platform_handle_;
- // The following members are only used when transferable_ is true;
+ // The following members are only used when transferable_ is false;
// The unique id shared by both ends of a non-transferable message pipe. This
// is held on until a read or write are done, and at that point it's used to
@@ -173,6 +179,7 @@ class MOJO_SYSTEM_IMPL_EXPORT MessagePipeDispatcher final
NonTransferableState non_transferable_state_;
// Messages that were written while we were waiting to get a RawChannel.
MessageInTransitQueue non_transferable_outgoing_message_queue_;
+ scoped_ptr<base::debug::StackTrace> non_transferable_bound_stack_;
// The following members are used for both modes of transferable_.
« no previous file with comments | « no previous file | mojo/edk/system/message_pipe_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698