Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1865)

Issue 1508053002: Add warning on DateTime.difference that DST + local-time is dangerous. (Closed)

Created:
5 years ago by Lasse Reichstein Nielsen
Modified:
5 years ago
Reviewers:
eernst
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add warning on DateTime.difference that DST + local-time is dangerous. Fixes issue #16527 BUG= http://dartbug.com/16527 R=eernst@google.com Committed: https://github.com/dart-lang/sdk/commit/6327b26652bf7d523e6e8044f56f96a233a8bb84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M sdk/lib/core/date_time.dart View 2 chunks +25 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Lasse Reichstein Nielsen
5 years ago (2015-12-08 10:25:11 UTC) #2
eernst
lgtm
5 years ago (2015-12-08 10:32:01 UTC) #3
Lasse Reichstein Nielsen
5 years ago (2015-12-08 10:45:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6327b26652bf7d523e6e8044f56f96a233a8bb84 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698