Add TimedCanvasDrawListener

third_party/WebKit/Source/modules/mediacapturefromelement/CanvasCaptureMediaStreamTrack.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CanvasCaptureMediaStreamTrack_h
 #define CanvasCaptureMediaStreamTrack_h
 
 #include "core/html/canvas/CanvasDrawListener.h"
 #include "modules/mediastream/MediaStreamTrack.h"
 #include "platform/heap/Handle.h"
 
 namespace blink {
 
 class HTMLCanvasElement;
 class WebCanvasCaptureHandler;
 
 class CanvasCaptureMediaStreamTrack final : public MediaStreamTrack {
     DEFINE_WRAPPERTYPEINFO();
-
 public:
-    static CanvasCaptureMediaStreamTrack* create(MediaStreamComponent*, PassRefPtrWillBeRawPtr<HTMLCanvasElement>, const PassOwnPtr<WebCanvasCaptureHandler>);
+    static CanvasCaptureMediaStreamTrack* create(MediaStreamComponent*, PassRefPtrWillBeRawPtr<HTMLCanvasElement>, const PassOwnPtr<WebCanvasCaptureHandler>, bool, double);

[esprehn, 2015/12/15 23:58:01]

Sorry I wasn't clear, the rule is all primitive types need the names. So the
bool and double need the names, not the handler or the canvas or the component.

The rule is: "Can I tell what this variable is for just from the type".

which is almost always false for primitives

[emircan, 2015/12/16 15:36:21]

Thanks, it makes sense now :)

 
     HTMLCanvasElement* canvas() const;
     void requestFrame();
 
     CanvasCaptureMediaStreamTrack* clone(ExecutionContext*) override;
 
     DECLARE_VIRTUAL_TRACE();
 
 private:
     CanvasCaptureMediaStreamTrack(const CanvasCaptureMediaStreamTrack&, MediaStreamComponent*);
-    CanvasCaptureMediaStreamTrack(MediaStreamComponent*, PassRefPtrWillBeRawPtr<HTMLCanvasElement>, const PassOwnPtr<WebCanvasCaptureHandler>);
+    CanvasCaptureMediaStreamTrack(MediaStreamComponent*, PassRefPtrWillBeRawPtr<HTMLCanvasElement>, const PassOwnPtr<WebCanvasCaptureHandler>, bool, double);

[esprehn, 2015/12/15 23:58:01]

add bool and double names

[emircan, 2015/12/16 15:36:21]

Done.

 
     RefPtrWillBeMember<HTMLCanvasElement> m_canvasElement;
     Member<CanvasDrawListener> m_drawListener;
 };
 
 } // namespace blink
 
 #endif