Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1508003003: Move default value of pdf_enable_xfa to standalone.gypi (Closed)

Created:
5 years ago by Tom Sepez
Modified:
5 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Move default value of pdf_enable_xfa to standalone.gypi This allows standalone pdfium builds to build with XFA, but makes a chromium checkout revert to non-xfa even on this branch. GN implies a chromium checkout at the moment, so disable XFA there, too. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d2e023bfe3c2ffe1e77bac464de7242f830b846f

Patch Set 1 #

Patch Set 2 : Fix pre-existing GN botch. #

Patch Set 3 : GN #

Patch Set 4 : Moar GN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -25 lines) Patch
M BUILD.gn View 1 2 3 11 chunks +35 lines, -21 lines 0 comments Download
M build/standalone.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M pdfium.gni View 1 chunk +1 line, -1 line 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -1 line 0 comments Download
M samples/BUILD.gn View 1 2 3 chunks +8 lines, -1 line 0 comments Download
M samples/samples.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Tom Sepez
For review.
5 years ago (2015-12-08 19:45:34 UTC) #3
Tom Sepez
On 2015/12/08 19:45:34, Tom Sepez wrote: > For review. The idea is that landing this ...
5 years ago (2015-12-08 19:57:15 UTC) #4
Lei Zhang
lgtm Please make sure both standalone and Chromium builds correctly.
5 years ago (2015-12-08 21:08:54 UTC) #5
Tom Sepez
On 2015/12/08 21:08:54, Lei Zhang wrote: > lgtm > > Please make sure both standalone ...
5 years ago (2015-12-08 21:40:25 UTC) #6
Tom Sepez
PS#4 fixes the GN issue. Please review it.
5 years ago (2015-12-08 21:49:13 UTC) #7
Lei Zhang
++lgtm
5 years ago (2015-12-08 22:23:14 UTC) #8
Tom Sepez
5 years ago (2015-12-08 22:36:21 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
d2e023bfe3c2ffe1e77bac464de7242f830b846f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698