Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 1508003002: Retain information on which standard objects are used in asm typer. (Closed)

Created:
5 years ago by bradn
Modified:
5 years ago
Reviewers:
titzer, aseemgarg, marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Retain information on which standard objects are used in asm typer. Reconstructing which stdlib object is used within an asm.js module seems wasteful, given the typer has already checked this. Preserving this information in a form that can be queried in the asm-wasm-builder which generating code. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=test-asm-validator, test-parsing R=titzer@chromium.org,marja@chromium.org,aseemgarg@chromium.org LOG=N Committed: https://crrev.com/f245717d9b18a9a877f6a77f96540b075dffcf43 Cr-Commit-Position: refs/heads/master@{#32687}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -34 lines) Patch
M src/typing-asm.h View 1 2 chunks +42 lines, -4 lines 0 comments Download
M src/typing-asm.cc View 1 9 chunks +91 lines, -21 lines 0 comments Download
M test/cctest/test-asm-validator.cc View 1 5 chunks +81 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
bradn
5 years ago (2015-12-08 01:17:48 UTC) #1
titzer
lgtm modulo naming https://codereview.chromium.org/1508003002/diff/1/src/typing-asm.h File src/typing-asm.h (right): https://codereview.chromium.org/1508003002/diff/1/src/typing-asm.h#newcode28 src/typing-asm.h:28: enum StandardObject { Better name here? ...
5 years ago (2015-12-08 10:27:20 UTC) #2
bradn
https://codereview.chromium.org/1508003002/diff/1/src/typing-asm.h File src/typing-asm.h (right): https://codereview.chromium.org/1508003002/diff/1/src/typing-asm.h#newcode28 src/typing-asm.h:28: enum StandardObject { On 2015/12/08 10:27:20, titzer wrote: > ...
5 years ago (2015-12-09 03:40:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1508003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1508003002/20001
5 years ago (2015-12-09 03:48:05 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-09 04:27:56 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-09 04:28:40 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f245717d9b18a9a877f6a77f96540b075dffcf43
Cr-Commit-Position: refs/heads/master@{#32687}

Powered by Google App Engine
This is Rietveld 408576698