Issue 15080009: Enable the side-effect free whitelist and use it for local browsing based

Issue 15080009: Enable the side-effect free whitelist and use it for local browsing based (Closed)

Created:
7 years, 7 months ago by tburkard

Modified:
7 years, 7 months ago

Reviewers:
Shishir, Brian Ryner

CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, Brian Ryner, Garrett Casto, Scott Hess - ex-Googler

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Enable the side-effect free whitelist and use it for local browsing based prerendering. R=bryner@chromium.org, shishir@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200398

Patch Set 4 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -4 lines)			Patch
M	chrome/browser/prerender/prerender_field_trial.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/prerender/prerender_local_predictor.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/prerender/prerender_local_predictor.cc	View		4 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/safe_browsing/database_manager.h	View	1 2 3	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/safe_browsing/database_manager.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Shishir

lgtm https://codereview.chromium.org/15080009/diff/14001/chrome/browser/safe_browsing/database_manager.cc File chrome/browser/safe_browsing/database_manager.cc (right): https://codereview.chromium.org/15080009/diff/14001/chrome/browser/safe_browsing/database_manager.cc#newcode273 chrome/browser/safe_browsing/database_manager.cc:273: return false; Add a header file comment for ...

7 years, 7 months ago (2013-05-16 00:19:17 UTC) #2

tburkard

https://codereview.chromium.org/15080009/diff/14001/chrome/browser/safe_browsing/database_manager.cc File chrome/browser/safe_browsing/database_manager.cc (right): https://codereview.chromium.org/15080009/diff/14001/chrome/browser/safe_browsing/database_manager.cc#newcode273 chrome/browser/safe_browsing/database_manager.cc:273: return false; On 2013/05/16 00:19:17, Shishir wrote: > Add ...

7 years, 7 months ago (2013-05-16 00:23:23 UTC) #3

tburkard

7 years, 7 months ago (2013-05-16 00:25:10 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r200398 (presubmit successful).

Expand Messages | Collapse Messages