Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Side by Side Diff: net/ocsp/nss_ocsp_unittest.cc

Issue 15080007: Introduce unit test for NSS OCSP/AIA fetching (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Be nicer when tests blow up Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/net.gyp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "net/ocsp/nss_ocsp.h"
6
7 #include <string>
8
9 #include "base/file_util.h"
10 #include "base/files/file_path.h"
11 #include "base/logging.h"
12 #include "base/memory/ref_counted.h"
13 #include "net/base/net_errors.h"
14 #include "net/base/test_completion_callback.h"
15 #include "net/base/test_data_directory.h"
16 #include "net/cert/cert_status_flags.h"
17 #include "net/cert/cert_verifier.h"
18 #include "net/cert/cert_verify_proc.h"
19 #include "net/cert/cert_verify_proc_nss.h"
20 #include "net/cert/cert_verify_result.h"
21 #include "net/cert/multi_threaded_cert_verifier.h"
22 #include "net/cert/test_root_certs.h"
23 #include "net/cert/x509_certificate.h"
24 #include "net/test/cert_test_util.h"
25 #include "net/url_request/url_request_filter.h"
26 #include "net/url_request/url_request_test_job.h"
27 #include "net/url_request/url_request_test_util.h"
28 #include "testing/gtest/include/gtest/gtest.h"
29
30 namespace net {
31
32 namespace {
33
34 // Matches the caIssuers hostname from the generated certificate.
35 const char kAiaHost[] = "aia-test.invalid";
36 // Returning a single DER-encoded cert, so the mime-type must be
37 // application/pkix-cert per RFC 5280.
38 const char kAiaHeaders[] = "HTTP/1.1 200 OK\0"
39 "Content-type: application/pkix-cert\0"
40 "\0";
41
42 class AiaResponseHandler : public net::URLRequestJobFactory::ProtocolHandler {
43 public:
44 AiaResponseHandler(const std::string& headers, const std::string& cert_data)
45 : headers_(headers), cert_data_(cert_data), request_count_(0) {}
46 virtual ~AiaResponseHandler() {}
47
48 // net::URLRequestJobFactory::ProtocolHandler implementation:
49 virtual net::URLRequestJob* MaybeCreateJob(
50 net::URLRequest* request,
51 net::NetworkDelegate* network_delegate) const OVERRIDE {
52 ++const_cast<AiaResponseHandler*>(this)->request_count_;
53
54 return new net::URLRequestTestJob(
55 request, network_delegate, headers_, cert_data_, true);
56 }
57
58 int request_count() const { return request_count_; }
59
60 private:
61 std::string headers_;
62 std::string cert_data_;
63 int request_count_;
64
65 DISALLOW_COPY_AND_ASSIGN(AiaResponseHandler);
66 };
67
68 } // namespace
69
70 class NssHttpTest : public ::testing::Test {
71 public:
72 NssHttpTest()
73 : context_(false),
74 handler_(NULL),
75 verify_proc_(new CertVerifyProcNSS),
76 verifier_(new MultiThreadedCertVerifier(verify_proc_)) {
77 }
78 virtual ~NssHttpTest() {}
79
80 virtual void SetUp() {
81 std::string file_contents;
82 ASSERT_TRUE(file_util::ReadFileToString(
83 GetTestCertsDirectory().AppendASCII("aia-intermediate.der"),
84 &file_contents));
85 ASSERT_FALSE(file_contents.empty());
86
87 // Ownership of |handler| is transferred to the URLRequestFilter, but
88 // hold onto the original pointer in order to access |request_count()|.
89 scoped_ptr<AiaResponseHandler> handler(
90 new AiaResponseHandler(kAiaHeaders, file_contents));
91 handler_ = handler.get();
92
93 URLRequestFilter::GetInstance()->AddHostnameProtocolHandler(
94 "http",
95 kAiaHost,
96 handler.PassAs<URLRequestJobFactory::ProtocolHandler>());
97
98 SetURLRequestContextForNSSHttpIO(&context_);
99 EnsureNSSHttpIOInit();
100 }
101
102 virtual void TearDown() {
103 ShutdownNSSHttpIO();
104
105 if (handler_)
106 URLRequestFilter::GetInstance()->RemoveHostnameHandler("http", kAiaHost);
107 }
108
109 CertVerifier* verifier() const {
110 return verifier_.get();
111 }
112
113 int request_count() const {
114 return handler_->request_count();
115 }
116
117 protected:
118 const CertificateList empty_cert_list_;
119
120 private:
121 TestURLRequestContext context_;
122 AiaResponseHandler* handler_;
123 scoped_refptr<CertVerifyProc> verify_proc_;
124 scoped_ptr<CertVerifier> verifier_;
125 };
126
127 // Tests that when using NSS to verify certificates, and IO is enabled,
128 // that a request to fetch missing intermediate certificates is
129 // made successfully.
130 TEST_F(NssHttpTest, TestAia) {
131 scoped_refptr<X509Certificate> test_cert(
132 ImportCertFromFile(GetTestCertsDirectory(), "aia-cert.pem"));
133 ASSERT_TRUE(test_cert.get());
134
135 scoped_refptr<X509Certificate> test_root(
136 ImportCertFromFile(GetTestCertsDirectory(), "aia-root.pem"));
137 ASSERT_TRUE(test_root.get());
138
139 ScopedTestRoot scoped_root(test_root);
140
141 CertVerifyResult verify_result;
142 TestCompletionCallback test_callback;
143 CertVerifier::RequestHandle request_handle;
144
145 int flags = CertVerifier::VERIFY_CERT_IO_ENABLED;
146 int error = verifier()->Verify(test_cert, "aia-host.invalid", flags, NULL,
147 &verify_result, test_callback.callback(),
148 &request_handle, BoundNetLog());
149 ASSERT_EQ(ERR_IO_PENDING, error);
150
151 error = test_callback.WaitForResult();
152
153 EXPECT_EQ(OK, error);
154
155 // Ensure that NSS made an AIA request for the missing intermediate.
156 EXPECT_LT(0, request_count());
157 }
158
159 } // namespace net
OLDNEW
« no previous file with comments | « net/net.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698