Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: tools/testing/dart/test_options.dart

Issue 1507943002: Add ./tools/test.py -c precompiler -r dart_precompiled. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_options.dart
diff --git a/tools/testing/dart/test_options.dart b/tools/testing/dart/test_options.dart
index 1113174f7d1e42d9caf51dc92e5e9d093db60b0a..36f3d86bfd6c90941a9dc506a3577413838beaa4 100644
--- a/tools/testing/dart/test_options.dart
+++ b/tools/testing/dart/test_options.dart
@@ -68,7 +68,8 @@ class TestOptionsParser {
dart2analyzer: Perform static analysis on Dart code by running the analyzer on Dart.
(only valid with the following runtimes: none)''',
['-c', '--compiler'],
- ['none', 'dart2js', 'dartanalyzer', 'dart2analyzer'],
+ ['none', 'precompiler',
+ 'dart2js', 'dartanalyzer', 'dart2analyzer'],
'none'),
// TODO(antonm): fix the option drt.
new _TestOptionSpecification(
@@ -76,6 +77,9 @@ class TestOptionsParser {
'''Where the tests should be run.
vm: Run Dart code on the standalone dart vm.
+ dart_precompiled: Run a precompiled snapshot on a variant of the standalone
+ dart vm lacking a JIT.
+
d8: Run JavaScript from the command line using v8.
jsshell: Run JavaScript from the command line using firefox js-shell.
@@ -96,7 +100,8 @@ class TestOptionsParser {
none: No runtime, compile only (for example, used for dartanalyzer static
analysis tests).''',
['-r', '--runtime'],
- ['vm', 'd8', 'jsshell', 'drt', 'dartium', 'ff', 'firefox',
+ ['vm', 'dart_precompiled', 'd8', 'jsshell', 'drt', 'dartium',
+ 'ff', 'firefox',
'chrome', 'safari', 'ie9', 'ie10', 'ie11', 'opera',
'chromeOnAndroid', 'safarimobilesim',
'ContentShellOnAndroid', 'DartiumOnAndroid', 'none'],
@@ -646,6 +651,9 @@ Note: currently only implemented for dart2js.''',
case 'dart2analyzer':
validRuntimes = const ['none'];
break;
+ case 'precompiler':
+ validRuntimes = const ['dart_precompiled'];
+ break;
case 'none':
validRuntimes = const ['vm', 'drt', 'dartium',
'ContentShellOnAndroid', 'DartiumOnAndroid'];

Powered by Google App Engine
This is Rietveld 408576698