Add ./tools/test.py -c precompiler -r dart_precompiled.

Add ./tools/test.py -c precompiler -r dart_precompiled.

 - Make --gen/run-precompiled-snapshot take a directory to use for the snapshot pieces.
 - Throw on Platform.executeable to prevent tests from becoming fork-bombs.
 - Update status files so 'dart_precompiled' is generally expected to behave the same as 'vm'.

Currently multitests will fail unless run with --jobs=1 because the test harness assigns them the same temporary directory.

Running this also requires a great deal of space. My out directory is 380G.

BUG=http://dartbug.com/24975
R=fschneider@google.com, srdjan@google.com

Committed: https://github.com/dart-lang/sdk/commit/6b964b83ac45d557ac721dadb7db1d3c47689c00

[rmacnak, 2015-12-17 01:03:48]

Description was changed from

==========
Reset unreached fields.

BUG=
==========

to

==========
Add ./tools/test.py -c precompiler -r dart_precompiled.

 - Make --gen/run-precompiled-snapshot take a directory to use for the snapshot
pieces.
 - Throw on Platform.executeable to prevent tests from becoming fork-bombs.
 - Update status files so 'dart_precompiled' is generally expected to behave the
same as 'vm'.

Currently multitests will fail unless run with --jobs=1 because the test harness
assigns them the same temporary directory.
==========

[rmacnak, 2015-12-17 01:04:01]

Description was changed from

==========
Add ./tools/test.py -c precompiler -r dart_precompiled.

 - Make --gen/run-precompiled-snapshot take a directory to use for the snapshot
pieces.
 - Throw on Platform.executeable to prevent tests from becoming fork-bombs.
 - Update status files so 'dart_precompiled' is generally expected to behave the
same as 'vm'.

Currently multitests will fail unless run with --jobs=1 because the test harness
assigns them the same temporary directory.
==========

to

==========
Add ./tools/test.py -c precompiler -r dart_precompiled.

 - Make --gen/run-precompiled-snapshot take a directory to use for the snapshot
pieces.
 - Throw on Platform.executeable to prevent tests from becoming fork-bombs.
 - Update status files so 'dart_precompiled' is generally expected to behave the
same as 'vm'.

Currently multitests will fail unless run with --jobs=1 because the test harness
assigns them the same temporary directory.
==========

[rmacnak, 2015-12-17 01:04:37]

Description was changed from

==========
Add ./tools/test.py -c precompiler -r dart_precompiled.

 - Make --gen/run-precompiled-snapshot take a directory to use for the snapshot
pieces.
 - Throw on Platform.executeable to prevent tests from becoming fork-bombs.
 - Update status files so 'dart_precompiled' is generally expected to behave the
same as 'vm'.

Currently multitests will fail unless run with --jobs=1 because the test harness
assigns them the same temporary directory.
==========

to

==========
Add ./tools/test.py -c precompiler -r dart_precompiled.

 - Make --gen/run-precompiled-snapshot take a directory to use for the snapshot
pieces.
 - Throw on Platform.executeable to prevent tests from becoming fork-bombs.
 - Update status files so 'dart_precompiled' is generally expected to behave the
same as 'vm'.

Currently multitests will fail unless run with --jobs=1 because the test harness
assigns them the same temporary directory.

BUG=http://dartbug.com/24975
==========

[rmacnak, 2015-12-17 01:09:37]

Description was changed from

==========
Add ./tools/test.py -c precompiler -r dart_precompiled.

 - Make --gen/run-precompiled-snapshot take a directory to use for the snapshot
pieces.
 - Throw on Platform.executeable to prevent tests from becoming fork-bombs.
 - Update status files so 'dart_precompiled' is generally expected to behave the
same as 'vm'.

Currently multitests will fail unless run with --jobs=1 because the test harness
assigns them the same temporary directory.

BUG=http://dartbug.com/24975
==========

to

==========
Add ./tools/test.py -c precompiler -r dart_precompiled.

 - Make --gen/run-precompiled-snapshot take a directory to use for the snapshot
pieces.
 - Throw on Platform.executeable to prevent tests from becoming fork-bombs.
 - Update status files so 'dart_precompiled' is generally expected to behave the
same as 'vm'.

Currently multitests will fail unless run with --jobs=1 because the test harness
assigns them the same temporary directory.

Running this also requires a great deal of space. My out directory is 380G.

BUG=http://dartbug.com/24975
==========

[rmacnak, 2015-12-17 01:31:23]

rmacnak@google.com changed reviewers:
+ fschneider@google.com, srdjan@google.com

[Florian Schneider, 2015-12-17 12:53:25]

Lgtm. Thanks for doing this!

Would it be possible use less temporary space so I can run them on my 160G SSD
disk?

https://codereview.chromium.org/1507943002/diff/40001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/1507943002/diff/40001/runtime/bin/main.cc#new...
runtime/bin/main.cc:1030: char* concat = reinterpret_cast<char*>(alloca(len +
1));
I would avoid alloca - it is not standard C++, and there seems no performance
reason for not using new/delete.

https://codereview.chromium.org/1507943002/diff/40001/runtime/bin/main.cc#new...
runtime/bin/main.cc:1055: char* concat = reinterpret_cast<char*>(alloca(len +
1));
Same here. Maybe something like this:

char* concat = NULL;

...

concat = new char[len + 1];

...

if (concat != NULL) delete[] concat;

https://codereview.chromium.org/1507943002/diff/40001/tests/co19/co19-runtime...
File tests/co19/co19-runtime.status (right):

https://codereview.chromium.org/1507943002/diff/40001/tests/co19/co19-runtime...
tests/co19/co19-runtime.status:41: [ ($compiler == none || $compiler ==
precompiler) && ($runtime == vm || $runtime == dart_precompiled) ]
Isn't ($compiler == none || $compiler == precompiler) redundant?

runtime == dart_precompiled implies compiler == precompiler, and runtime == vm
implies compiler == none, right?

This would simplify a lot of conditions.

https://codereview.chromium.org/1507943002/diff/40001/tools/testing/dart/comp...
File tools/testing/dart/compiler_configuration.dart (right):

https://codereview.chromium.org/1507943002/diff/40001/tools/testing/dart/comp...
tools/testing/dart/compiler_configuration.dart:343: String outputFileName,
This is really the directory, right?

s/outputFileName/tempDir/

[rmacnak, 2015-12-17 19:20:51]

Re space, if I can find how to delete the output directory after a test passes,
it should use only hundreds of MB.

https://codereview.chromium.org/1507943002/diff/40001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/1507943002/diff/40001/runtime/bin/main.cc#new...
runtime/bin/main.cc:1030: char* concat = reinterpret_cast<char*>(alloca(len +
1));
On 2015/12/17 12:53:25, Florian Schneider wrote:
> I would avoid alloca - it is not standard C++, and there seems no performance
> reason for not using new/delete.

Done.

https://codereview.chromium.org/1507943002/diff/40001/runtime/bin/main.cc#new...
runtime/bin/main.cc:1055: char* concat = reinterpret_cast<char*>(alloca(len +
1));
On 2015/12/17 12:53:25, Florian Schneider wrote:
> Same here. Maybe something like this:
> 
> char* concat = NULL;
> 
> ...
> 
> concat = new char[len + 1];
> 
> ...
> 
> if (concat != NULL) delete[] concat;

Done.

https://codereview.chromium.org/1507943002/diff/40001/tests/co19/co19-runtime...
File tests/co19/co19-runtime.status (right):

https://codereview.chromium.org/1507943002/diff/40001/tests/co19/co19-runtime...
tests/co19/co19-runtime.status:41: [ ($compiler == none || $compiler ==
precompiler) && ($runtime == vm || $runtime == dart_precompiled) ]
On 2015/12/17 12:53:25, Florian Schneider wrote:
> Isn't ($compiler == none || $compiler == precompiler) redundant?
> 
> runtime == dart_precompiled implies compiler == precompiler, and runtime == vm
> implies compiler == none, right?
> 
> This would simplify a lot of conditions.

Maybe. In the past it was possible to have compiler == dart2dart && runtime ==
vm. Let's try removing the $compiler == none in a separate CL.

https://codereview.chromium.org/1507943002/diff/40001/tools/testing/dart/comp...
File tools/testing/dart/compiler_configuration.dart (right):

https://codereview.chromium.org/1507943002/diff/40001/tools/testing/dart/comp...
tools/testing/dart/compiler_configuration.dart:343: String outputFileName,
On 2015/12/17 12:53:25, Florian Schneider wrote:
> This is really the directory, right?
> 
> s/outputFileName/tempDir/

Yes.

[srdjan, 2015-12-17 20:39:17]

lgtm

https://codereview.chromium.org/1507943002/diff/60001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/1507943002/diff/60001/runtime/bin/main.cc#new...
runtime/bin/main.cc:324: }
Maybe shorter:
if ((arg[0] == '=') || (arg[0] == ':') {
  precompiled_snapshot_directory = &precompiled_snapshot_directory[1];
} else {
  precompiled_snapshot_directory = arg;
}

[rmacnak, 2015-12-18 20:05:54]

https://codereview.chromium.org/1507943002/diff/60001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/1507943002/diff/60001/runtime/bin/main.cc#new...
runtime/bin/main.cc:324: }
On 2015/12/17 20:39:17, srdjan wrote:
> Maybe shorter:
> if ((arg[0] == '=') || (arg[0] == ':') {
>   precompiled_snapshot_directory = &precompiled_snapshot_directory[1];
> } else {
>   precompiled_snapshot_directory = arg;
> }

Done.

[rmacnak, 2015-12-18 20:08:13]

Description was changed from

==========
Add ./tools/test.py -c precompiler -r dart_precompiled.

 - Make --gen/run-precompiled-snapshot take a directory to use for the snapshot
pieces.
 - Throw on Platform.executeable to prevent tests from becoming fork-bombs.
 - Update status files so 'dart_precompiled' is generally expected to behave the
same as 'vm'.

Currently multitests will fail unless run with --jobs=1 because the test harness
assigns them the same temporary directory.

Running this also requires a great deal of space. My out directory is 380G.

BUG=http://dartbug.com/24975
==========

to

==========
Add ./tools/test.py -c precompiler -r dart_precompiled.

 - Make --gen/run-precompiled-snapshot take a directory to use for the snapshot
pieces.
 - Throw on Platform.executeable to prevent tests from becoming fork-bombs.
 - Update status files so 'dart_precompiled' is generally expected to behave the
same as 'vm'.

Currently multitests will fail unless run with --jobs=1 because the test harness
assigns them the same temporary directory.

Running this also requires a great deal of space. My out directory is 380G.

BUG=http://dartbug.com/24975
R=fschneider@google.com, srdjan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6b964b83ac45d557ac721dadb7db1d3c47689c00
==========

[rmacnak, 2015-12-18 20:08:14]

Committed patchset #5 (id:80001) manually as
6b964b83ac45d557ac721dadb7db1d3c47689c00 (presubmit successful).