pkg/analyzer/lib/src/task/dart.dart - Issue 1507933002: Refactor strong mode to remove duplicate TypeRules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/task/dart.dart

Issue 1507933002: Refactor strong mode to remove duplicate TypeRules (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/task/dart.dart

diff --git a/pkg/analyzer/lib/src/task/dart.dart b/pkg/analyzer/lib/src/task/dart.dart

index 1a5046d0491a23b9a77e1648fa413dd0e3490c1c..52144b5ec76415e7ef58bdda211782895c37aed9 100644

--- a/pkg/analyzer/lib/src/task/dart.dart

+++ b/pkg/analyzer/lib/src/task/dart.dart

@@ -30,7 +30,6 @@ import 'package:analyzer/src/task/html.dart';

import 'package:analyzer/src/task/inputs.dart';

import 'package:analyzer/src/task/model.dart';

import 'package:analyzer/src/task/strong/checker.dart';

-import 'package:analyzer/src/task/strong/rules.dart';

import 'package:analyzer/src/task/strong_mode.dart';

import 'package:analyzer/task/dart.dart';

import 'package:analyzer/task/general.dart';

@@ -5007,7 +5006,8 @@ class StrongModeVerifyUnitTask extends SourceBasedAnalysisTask {

TypeProvider typeProvider = getRequiredInput(TYPE_PROVIDER_INPUT);

CompilationUnit unit = getRequiredInput(UNIT_INPUT);

if (context.analysisOptions.strongMode) {

- unit.accept(new CodeChecker(new TypeRules(typeProvider), errorListener));

+ unit.accept(new CodeChecker(

+ typeProvider, new StrongTypeSystemImpl(), errorListener));

}