Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Issue 1507923002: - Make sure the tar file for Observatory resources only contains (Closed)

Created:
5 years ago by Ivan Posva
Modified:
5 years ago
Reviewers:
rmacnak, Cutch
CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Make sure the tar file for Observatory resources only contains forward slashes. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/5805cba963e4b0c8ff1d5a11f245b23b7aa110f8

Patch Set 1 #

Patch Set 2 : Add comment. #

Patch Set 3 : TABS to spaces. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M runtime/tools/create_archive.py View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Ivan Posva
5 years ago (2015-12-07 23:08:30 UTC) #2
rmacnak
lgtm
5 years ago (2015-12-07 23:25:32 UTC) #3
Ivan Posva
5 years ago (2015-12-07 23:27:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
5805cba963e4b0c8ff1d5a11f245b23b7aa110f8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698