Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: public/common/WebPrivateOwnPtr.h

Issue 15079005: Create a minimal webkit_common static library for use in browser process (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/common/WebPrivateOwnPtr.h
diff --git a/public/platform/WebPrivateOwnPtr.h b/public/common/WebPrivateOwnPtr.h
similarity index 92%
copy from public/platform/WebPrivateOwnPtr.h
copy to public/common/WebPrivateOwnPtr.h
index 4bcabcfe685316b452e589fd980ef1e207aa9dae..ef581955b368319fce069ecc43085e5867d162f3 100644
--- a/public/platform/WebPrivateOwnPtr.h
+++ b/public/common/WebPrivateOwnPtr.h
@@ -26,11 +26,11 @@
#ifndef WebPrivateOwnPtr_h
#define WebPrivateOwnPtr_h
-#include "WebCommon.h"
+#include "WebAssertion.h"
namespace WebKit {
-// This class is an implementation detail of the WebKit API. It exists
+// This class is an implementation detail of the WebKit API. It exists
// to help simplify the implementation of WebKit interfaces that merely
// wrap a pointer to a WebCore class. It's similar to WebPrivatePtr, but it
// wraps a naked pointer rather than a reference counted.
@@ -39,10 +39,10 @@ namespace WebKit {
template <typename T>
class WebPrivateOwnPtr {
public:
- WebPrivateOwnPtr() : m_ptr(0) {}
+ WebPrivateOwnPtr() : m_ptr(0) { }
~WebPrivateOwnPtr() { WEBKIT_ASSERT(!m_ptr); }
-#if WEBKIT_IMPLEMENTATION
+#if INSIDE_WEBKIT
explicit WebPrivateOwnPtr(T* ptr)
: m_ptr(ptr)
{
@@ -61,7 +61,7 @@ public:
WEBKIT_ASSERT(m_ptr);
return m_ptr;
}
-#endif // WEBKIT_IMPLEMENTATION
+#endif // INSIDE_WEBKIT
private:
T* m_ptr;

Powered by Google App Engine
This is Rietveld 408576698