Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1507893004: Revert of Mac: Require child AllocateGpuMemoryBuffer to not fail (Closed)

Created:
5 years ago by ccameron
Modified:
5 years ago
CC:
chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, sievers+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mac: Require child AllocateGpuMemoryBuffer to not fail (patchset #3 id:40001 of https://codereview.chromium.org/1486873002/ ) Reason for revert: Causing lots of crashes. Original issue's description: > Mac: Require child AllocateGpuMemoryBuffer to not fail > > It is already the case that this will cause a crash in the renderer > process when it dereferences the GpuMemoryBuffer. Move this higher up > the stack. > > BUG=561672 > > Committed: https://crrev.com/d34a0fd2b9080114bd22ad148f8e37da2b3a24f1 > Cr-Commit-Position: refs/heads/master@{#363222} TBR=reveman@chromium.org,avi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=561672 Committed: https://crrev.com/17d4326bf4bf6ab4c823de40d15e1fc79d5a6806 Cr-Commit-Position: refs/heads/master@{#363667}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M content/child/child_gpu_memory_buffer_manager.cc View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ccameron
Created Revert of Mac: Require child AllocateGpuMemoryBuffer to not fail
5 years ago (2015-12-08 00:54:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507893004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507893004/1
5 years ago (2015-12-08 00:59:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507893004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507893004/1
5 years ago (2015-12-08 01:04:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-08 01:13:23 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-08 01:14:35 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17d4326bf4bf6ab4c823de40d15e1fc79d5a6806
Cr-Commit-Position: refs/heads/master@{#363667}

Powered by Google App Engine
This is Rietveld 408576698