Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1507893002: Revert "Rename CFWL_Thread classes to ThreadImp" (Closed)

Created:
5 years ago by Tom Sepez
Modified:
5 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Revert "Rename CFWL_Thread classes to ThreadImp" This reverts commit 6fa20c60c6ed551af55bfc879668eaac5c237805. Reason for revert: broke tests TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/5e4f290e939ded90a518ff8eab1db59930655e11

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -51 lines) Patch
M xfa/include/fwl/adapter/fwl_adapterthreadmgr.h View 2 chunks +15 lines, -4 lines 0 comments Download
M xfa/include/fwl/core/fwl_thread.h View 1 chunk +32 lines, -10 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_threadimp.cpp View 1 chunk +106 lines, -9 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_widgetimp.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/core/include/fwl_appimp.h View 2 chunks +6 lines, -9 lines 0 comments Download
M xfa/src/fwl/src/core/include/fwl_noteimp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/core/include/fwl_threadimp.h View 1 chunk +12 lines, -13 lines 0 comments Download
M xfa/src/fwl/src/core/include/fwl_widgetimp.h View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fwladapter.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
TBR, red tree.
5 years ago (2015-12-07 21:12:31 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as 5e4f290e939ded90a518ff8eab1db59930655e11 (tree was closed).
5 years ago (2015-12-07 21:12:54 UTC) #3
Lei Zhang
5 years ago (2015-12-07 21:36:13 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698