Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 150783002: Aligns the Q A Z keys on the a11y keyboard. (Closed)

Created:
6 years, 10 months ago by rsadam
Modified:
6 years, 10 months ago
Reviewers:
bshe, kevers
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Aligns the Q A Z keys on the a11y keyboard. BUG=297132 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248582

Patch Set 1 : #

Patch Set 2 : Make mic smaller. #

Total comments: 4

Patch Set 3 : Minor fixes, and resized microphone. #

Patch Set 4 : Change space bar color and fix font size bug. #

Total comments: 6

Patch Set 5 : Code refactor. #

Patch Set 6 : Minor css tweaks. #

Total comments: 6

Patch Set 7 : Fix nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -47 lines) Patch
M ui/keyboard/resources/constants.js View 1 2 3 4 5 2 chunks +6 lines, -4 lines 0 comments Download
M ui/keyboard/resources/layouts/system-qwerty.html View 1 2 3 4 5 6 3 chunks +24 lines, -25 lines 0 comments Download
M ui/keyboard/resources/main.js View 1 2 3 4 5 6 4 chunks +26 lines, -18 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
rsadam
6 years, 10 months ago (2014-01-30 21:26:29 UTC) #1
rsadam
Made the search icon the same size as the mic icon used to be.
6 years, 10 months ago (2014-01-30 22:51:17 UTC) #2
rsadam
Forgot to change it on both lower and upper.
6 years, 10 months ago (2014-01-30 23:16:14 UTC) #3
bshe
lgtm I am not familiar with the layout algorithm. You may want kevers@ to do ...
6 years, 10 months ago (2014-01-31 16:09:49 UTC) #4
rsadam
+kevers as a reviewer Yeah the weights no longer have to add up. It'll base ...
6 years, 10 months ago (2014-01-31 16:22:29 UTC) #5
rsadam
6 years, 10 months ago (2014-01-31 19:23:01 UTC) #6
rsadam
6 years, 10 months ago (2014-01-31 19:55:39 UTC) #7
kevers
https://codereview.chromium.org/150783002/diff/240001/ui/keyboard/resources/constants.js File ui/keyboard/resources/constants.js (right): https://codereview.chromium.org/150783002/diff/240001/ui/keyboard/resources/constants.js#newcode16 ui/keyboard/resources/constants.js:16: STRETCHRIGHT: "stretchright" This is a non-standard term and deserves ...
6 years, 10 months ago (2014-01-31 20:11:00 UTC) #8
rsadam
https://codereview.chromium.org/150783002/diff/240001/ui/keyboard/resources/constants.js File ui/keyboard/resources/constants.js (right): https://codereview.chromium.org/150783002/diff/240001/ui/keyboard/resources/constants.js#newcode16 ui/keyboard/resources/constants.js:16: STRETCHRIGHT: "stretchright" On 2014/01/31 20:11:00, kevers wrote: > This ...
6 years, 10 months ago (2014-01-31 20:40:18 UTC) #9
rsadam
Made some minor css tweaks based on the css discussions earlier today.
6 years, 10 months ago (2014-02-03 18:17:39 UTC) #10
kevers
LGTM with nits. https://codereview.chromium.org/150783002/diff/390001/ui/keyboard/resources/constants.js File ui/keyboard/resources/constants.js (right): https://codereview.chromium.org/150783002/diff/390001/ui/keyboard/resources/constants.js#newcode9 ui/keyboard/resources/constants.js:9: var ASPECT_RATIO = 3.5; Have you ...
6 years, 10 months ago (2014-02-03 19:00:59 UTC) #11
rsadam
https://codereview.chromium.org/150783002/diff/390001/ui/keyboard/resources/constants.js File ui/keyboard/resources/constants.js (right): https://codereview.chromium.org/150783002/diff/390001/ui/keyboard/resources/constants.js#newcode9 ui/keyboard/resources/constants.js:9: var ASPECT_RATIO = 3.5; On 2014/02/03 19:01:00, kevers wrote: ...
6 years, 10 months ago (2014-02-03 19:36:21 UTC) #12
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 10 months ago (2014-02-03 19:36:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/150783002/460001
6 years, 10 months ago (2014-02-03 19:38:06 UTC) #14
commit-bot: I haz the power
Change committed as 248582
6 years, 10 months ago (2014-02-03 21:59:51 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 21:59:53 UTC) #16
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 21:59:58 UTC) #17
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698