Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1829)

Issue 1507813004: Remove unnecessary 'noSuchMethod' declarations. (Closed)

Created:
5 years ago by scheglov
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove unnecessary 'noSuchMethod' declarations. Also format these file. I don't like how the new formatter changed the code :-( R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/72cf3cbe91b9215c03f0bb032192490c6c77f56a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -109 lines) Patch
M pkg/analysis_server/test/analysis/update_content_test.dart View 3 chunks +7 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/mocks.dart View 6 chunks +3 lines, -23 lines 0 comments Download
M pkg/analysis_server/test/operation/operation_queue_test.dart View 4 chunks +2 lines, -16 lines 0 comments Download
M pkg/analysis_server/test/protocol_server_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/index/dart_index_contributor_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/index/store/mocks.dart View 1 chunk +4 lines, -12 lines 0 comments Download
M pkg/analysis_server/test/services/index/store/split_store_test.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/services/search/search_engine_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analyzer/test/src/context/cache_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_work_manager_test.dart View 3 chunks +5 lines, -14 lines 0 comments Download
M pkg/analyzer/test/src/task/driver_test.dart View 2 chunks +1 line, -5 lines 0 comments Download
M pkg/analyzer/test/src/task/general_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analyzer/test/src/task/html_work_manager_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/task/options_work_manager_test.dart View 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
5 years ago (2015-12-08 19:31:51 UTC) #1
Brian Wilkerson
LGTM
5 years ago (2015-12-08 19:38:42 UTC) #2
scheglov
5 years ago (2015-12-08 19:39:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
72cf3cbe91b9215c03f0bb032192490c6c77f56a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698