Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: components/page_load_metrics/browser/page_load_metrics_util.h

Issue 1507813002: Don't log background navigations in StaleWhileRevalidateExperiment histograms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move ShouldLogEvent() to page_load_metrics_util. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/page_load_metrics/browser/page_load_metrics_util.h
diff --git a/components/page_load_metrics/browser/page_load_metrics_util.h b/components/page_load_metrics/browser/page_load_metrics_util.h
index b5a569867db22bd488ace4ac2009a0f5f3b4a872..f3e6260fc04ea648c770255046cc04628444a9e1 100644
--- a/components/page_load_metrics/browser/page_load_metrics_util.h
+++ b/components/page_load_metrics/browser/page_load_metrics_util.h
@@ -22,6 +22,14 @@ struct PageLoadTiming;
// Painting of a background color is not considered 'contentful'.
base::TimeDelta GetFirstContentfulPaint(const PageLoadTiming& timing);
+// Returns false for events for which we have no timing information, and events
+// that happened after the page was backgrounded. When a page is backgrounded,
+// the priority is lowered, and the load timing events no longer reflect the
Charlie Harrison 2015/12/08 20:26:21 I don't know if the priority is always lowered. rd
Adam Rice 2015/12/09 06:29:00 I reworded the comment. PTAL.
+// user experience. Since these data points can skew the mean, they should not
+// be mixed with timing events that occurred in the foreground.
+bool EventOccurredInForeground(const base::TimeDelta& event,
+ const base::TimeDelta& first_background);
+
} // namespace page_load_metrics
#endif // COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_UTIL_H_

Powered by Google App Engine
This is Rietveld 408576698