Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Side by Side Diff: chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc

Issue 1507813002: Don't log background navigations in StaleWhileRevalidateExperiment histograms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make EventOccurredInForeground take a PageLoadExtraInfo object. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/page_load_metrics/observers/stale_while_revalidate_metr ics_observer.h" 5 #include "chrome/browser/page_load_metrics/observers/stale_while_revalidate_metr ics_observer.h"
6 6
7 #include "components/page_load_metrics/browser/page_load_metrics_util.h" 7 #include "components/page_load_metrics/browser/page_load_metrics_util.h"
8 #include "components/page_load_metrics/common/page_load_timing.h" 8 #include "components/page_load_metrics/common/page_load_timing.h"
9 #include "content/public/browser/navigation_handle.h" 9 #include "content/public/browser/navigation_handle.h"
10 #include "net/base/stale_while_revalidate_experiment_domains.h" 10 #include "net/base/stale_while_revalidate_experiment_domains.h"
11 11
12 namespace chrome { 12 namespace chrome {
13 13
14 StaleWhileRevalidateMetricsObserver::StaleWhileRevalidateMetricsObserver( 14 StaleWhileRevalidateMetricsObserver::StaleWhileRevalidateMetricsObserver(
15 page_load_metrics::PageLoadMetricsObservable* metrics) 15 page_load_metrics::PageLoadMetricsObservable* metrics)
16 : is_interesting_domain_(false), metrics_(metrics) {} 16 : is_interesting_domain_(false), metrics_(metrics) {}
17 17
18 void StaleWhileRevalidateMetricsObserver::OnCommit( 18 void StaleWhileRevalidateMetricsObserver::OnCommit(
19 content::NavigationHandle* navigation_handle) { 19 content::NavigationHandle* navigation_handle) {
20 is_interesting_domain_ = net::IsHostInStaleWhileRevalidateExperimentDomain( 20 is_interesting_domain_ = net::IsHostInStaleWhileRevalidateExperimentDomain(
21 navigation_handle->GetURL().host()); 21 navigation_handle->GetURL().host());
22 } 22 }
23 23
24 void StaleWhileRevalidateMetricsObserver::OnComplete( 24 void StaleWhileRevalidateMetricsObserver::OnComplete(
25 const page_load_metrics::PageLoadTiming& timing, 25 const page_load_metrics::PageLoadTiming& timing,
26 const page_load_metrics::PageLoadExtraInfo& extra_info) { 26 const page_load_metrics::PageLoadExtraInfo& extra_info) {
27 using page_load_metrics::EventOccurredInForeground;
28
27 if (!is_interesting_domain_) 29 if (!is_interesting_domain_)
28 return; 30 return;
29 31
30 if (!timing.load_event_start.is_zero()) { 32 if (EventOccurredInForeground(timing.load_event_start, extra_info)) {
31 PAGE_LOAD_HISTOGRAM( 33 PAGE_LOAD_HISTOGRAM(
32 "PageLoad.Clients.StaleWhileRevalidateExperiment.Timing2." 34 "PageLoad.Clients.StaleWhileRevalidateExperiment.Timing2."
33 "NavigationToLoadEventFired", 35 "NavigationToLoadEventFired",
34 timing.load_event_start); 36 timing.load_event_start);
35 } 37 }
36 if (!timing.first_layout.is_zero()) { 38 if (EventOccurredInForeground(timing.first_layout, extra_info)) {
37 PAGE_LOAD_HISTOGRAM( 39 PAGE_LOAD_HISTOGRAM(
38 "PageLoad.Clients.StaleWhileRevalidateExperiment.Timing2." 40 "PageLoad.Clients.StaleWhileRevalidateExperiment.Timing2."
39 "NavigationToFirstLayout", 41 "NavigationToFirstLayout",
40 timing.first_layout); 42 timing.first_layout);
41 } 43 }
42 if (!timing.first_text_paint.is_zero()) { 44 if (EventOccurredInForeground(timing.first_text_paint, extra_info)) {
43 PAGE_LOAD_HISTOGRAM( 45 PAGE_LOAD_HISTOGRAM(
44 "PageLoad.Clients.StaleWhileRevalidateExperiment.Timing2." 46 "PageLoad.Clients.StaleWhileRevalidateExperiment.Timing2."
45 "NavigationToFirstTextPaint", 47 "NavigationToFirstTextPaint",
46 timing.first_text_paint); 48 timing.first_text_paint);
47 } 49 }
48 } 50 }
49 51
50 void StaleWhileRevalidateMetricsObserver::OnPageLoadMetricsGoingAway() { 52 void StaleWhileRevalidateMetricsObserver::OnPageLoadMetricsGoingAway() {
51 metrics_->RemoveObserver(this); 53 metrics_->RemoveObserver(this);
52 delete this; 54 delete this;
53 } 55 }
54 56
55 } // namespace chrome 57 } // namespace chrome
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698