Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1507723003: Set CHROME_DEVEL_SANDBOX environment variable. (Closed)

Created:
5 years ago by Ken Russell (switch to Gerrit)
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set CHROME_DEVEL_SANDBOX environment variable. This logic is moving from recipes to the src-side script. BUG=561863 Committed: https://crrev.com/00ab61a366648ab624d9a7d6a248b2fa0caf8e5d Cr-Commit-Position: refs/heads/master@{#363743}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M testing/scripts/run_telemetry_benchmark_as_googletest.py View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Ken Russell (switch to Gerrit)
Please review. Thanks. This is blocking re-landing the switch of the GPU bots to the ...
5 years ago (2015-12-08 01:25:31 UTC) #2
Ken Russell (switch to Gerrit)
FYI, tested locally on Linux. Doesn't break anything. Will make the bots work.
5 years ago (2015-12-08 01:27:14 UTC) #3
iannucci
lgtm
5 years ago (2015-12-08 01:30:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507723003/1
5 years ago (2015-12-08 01:34:09 UTC) #6
Dirk Pranke
lgtm
5 years ago (2015-12-08 01:40:42 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/145916)
5 years ago (2015-12-08 02:43:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507723003/1
5 years ago (2015-12-08 04:00:23 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-08 05:06:42 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-08 05:07:33 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00ab61a366648ab624d9a7d6a248b2fa0caf8e5d
Cr-Commit-Position: refs/heads/master@{#363743}

Powered by Google App Engine
This is Rietveld 408576698