DescriptionAdd safety when the .src attribute of an <audio> or <video> element is changed and it's used with the Web Audio API
When this happens, the underlying WebMediaPlayer is changed, with the old one destroyed and the new one created.
We need to take care to synchronize this destruction of the old WebMediaPlayer.
Part of this change involves making sure WebMediaPlayerClientImpl::AudioSourceProviderImpl::wrap(0)
calls WebAudioSourceProvider::setClient(0) for the old WebAudioSourceProvider.
We also add locking in the WebMediaPlayerClientImpl::AudioSourceProviderImpl methods.
BUG=239897
R=abarth@chromium.org, dalecurtis@chromium.org, kbr@chromium.org
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150330
Patch Set 1 #Patch Set 2 : add locking #Patch Set 3 : don't call WebAudioSourceProvider::provideInput() if client is not set #
Messages
Total messages: 8 (0 generated)
|