Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 15077011: Add safety when the .src attribute of an <audio> or <video> element is changed and it's used with t… (Closed)

Created:
7 years, 7 months ago by Chris Rogers
Modified:
7 years, 7 months ago
CC:
blink-reviews, feature-media-reviews_chromium.org, eae+blinkwatch
Visibility:
Public.

Description

Add safety when the .src attribute of an <audio> or <video> element is changed and it's used with the Web Audio API When this happens, the underlying WebMediaPlayer is changed, with the old one destroyed and the new one created. We need to take care to synchronize this destruction of the old WebMediaPlayer. Part of this change involves making sure WebMediaPlayerClientImpl::AudioSourceProviderImpl::wrap(0) calls WebAudioSourceProvider::setClient(0) for the old WebAudioSourceProvider. We also add locking in the WebMediaPlayerClientImpl::AudioSourceProviderImpl methods. BUG=239897 R=abarth@chromium.org, dalecurtis@chromium.org, kbr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150330

Patch Set 1 #

Patch Set 2 : add locking #

Patch Set 3 : don't call WebAudioSourceProvider::provideInput() if client is not set #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp View 1 2 3 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Chris Rogers
7 years, 7 months ago (2013-05-13 22:45:40 UTC) #1
acolwell GONE FROM CHROMIUM
A couple quick questions. The lock is needed because one of those three methods are ...
7 years, 7 months ago (2013-05-13 22:58:54 UTC) #2
Ken Russell (switch to Gerrit)
LGTM
7 years, 7 months ago (2013-05-13 23:42:50 UTC) #3
Chris Rogers
On 2013/05/13 22:58:54, acolwell wrote: > A couple quick questions. The lock is needed because ...
7 years, 7 months ago (2013-05-13 23:47:02 UTC) #4
Chris Rogers
jamesr: OWNERS rubber-stamp please?
7 years, 7 months ago (2013-05-13 23:48:25 UTC) #5
DaleCurtis
lgtm
7 years, 7 months ago (2013-05-13 23:48:33 UTC) #6
abarth-chromium
Mutex.... ok. LGTM
7 years, 7 months ago (2013-05-14 18:52:23 UTC) #7
Chris Rogers
7 years, 7 months ago (2013-05-14 19:03:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r150330 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698