Issue 15077008: add separate impl file for SkFontMgr_fontconfig, so we don't polute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15077008: add separate impl file for SkFontMgr_fontconfig, so we don't polute (Closed)

Created:
7 years, 7 months ago by reed1

Modified:
7 years, 7 months ago

Reviewers:
djsollen

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/

Visibility:
Public.

More Reviews

Description

add separate impl file for SkFontMgr_fontconfig, so we don't polute SkFontHost_fontconfig, which should be sharable w/ android. Eventaully we will remove that FontHost file completely, and just use the SkFontMgr. R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=9114

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+285 lines, -253 lines)			Patch
M	trunk/gyp/ports.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	trunk/src/fonts/SkFontMgr_fontconfig.cpp	View	1 chunk	+276 lines, -0 lines	0 comments	Download
M	trunk/src/ports/SkFontHost_fontconfig.cpp	View	2 chunks	+8 lines, -253 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

reed1

7 years, 7 months ago (2013-05-13 19:44:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r9114 (presubmit successful).

Expand Messages | Collapse Messages