Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1507683005: [Interpreter] Removes ToBoolean bytecode. (Closed)

Created:
5 years ago by mythria
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Removes ToBoolean bytecode. ToBoolean was used with conditional jumps. An earlier cl (https://codereview.chromium.org/1426913002/) merges jumps and ToBoolean into a single bytecode. So, we no longer need ToBoolean bytecode. BUG=v8:4280 LOG=N Committed: https://crrev.com/3b6773ba3d1ce80cc41213a9d85b335c40f552ba Cr-Commit-Position: refs/heads/master@{#32707}

Patch Set 1 #

Patch Set 2 : Rebased the patch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -152 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 2 chunks +0 lines, -34 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 1 chunk +0 lines, -37 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 2 chunks +0 lines, -63 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
mythria
Could you please review this cl. Thanks, Mythri
5 years ago (2015-12-08 09:34:00 UTC) #2
rmcilroy
lgtm, thanks.
5 years ago (2015-12-08 10:40:51 UTC) #4
oth
cool! lgtm
5 years ago (2015-12-08 10:46:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507683005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507683005/1
5 years ago (2015-12-09 09:48:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8710)
5 years ago (2015-12-09 09:59:47 UTC) #9
mythria
Michi, Could you please review this cl especially on the compiler side. Thanks, Mythri
5 years ago (2015-12-09 10:33:12 UTC) #11
Michael Starzinger
LGTM on "compiler".
5 years ago (2015-12-09 10:37:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507683005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507683005/1
5 years ago (2015-12-09 10:45:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507683005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507683005/20001
5 years ago (2015-12-09 10:55:18 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-09 11:29:31 UTC) #20
commit-bot: I haz the power
5 years ago (2015-12-09 11:29:41 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3b6773ba3d1ce80cc41213a9d85b335c40f552ba
Cr-Commit-Position: refs/heads/master@{#32707}

Powered by Google App Engine
This is Rietveld 408576698