Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1507673002: Unify quoting style in android_shell.py. (Closed)

Created:
5 years ago by ppi
Modified:
5 years ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Unify quoting style in android_shell.py. This patch unifies on single-quoutes in `android_shell.py`, in line with the rest of devtools. Also removes a stray semicolon. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b4d2fb056b85f743045373dbc78776a329d41d9b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M mojo/devtools/common/devtoolslib/android_shell.py View 8 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ppi
Hi Ben, ptal.
5 years ago (2015-12-07 14:21:56 UTC) #1
qsr
lgtm
5 years ago (2015-12-07 14:22:57 UTC) #2
ppi
5 years ago (2015-12-07 14:30:39 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b4d2fb056b85f743045373dbc78776a329d41d9b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698