Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Issue 1507633004: Simplify D1G so that it can inline DrawOneGlyph, and fix a bug in codegen (Closed)

Created:
5 years ago by herb_g
Modified:
5 years ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Simplify D1G so that it can inline DrawOneGlyph, and fix a bug in codegen that only happens on ARM64 using GCC 4.9. Committed: https://skia.googlesource.com/skia/+/d4c24f67496ff2e5e83bc7ce7945cbb85484bfa6

Patch Set 1 #

Patch Set 2 : fix spacing. #

Patch Set 3 : untabify #

Patch Set 4 : more spacing #

Patch Set 5 : delete line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -167 lines) Patch
M src/core/SkDraw.cpp View 4 chunks +104 lines, -165 lines 0 comments Download
M src/core/SkFindAndPlaceGlyph.h View 1 2 3 4 8 chunks +23 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507633004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507633004/1
5 years ago (2015-12-07 16:42:50 UTC) #2
herb_g
fix spacing.
5 years ago (2015-12-07 16:49:27 UTC) #3
herb_g
delete line
5 years ago (2015-12-07 17:37:04 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507633004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507633004/80001
5 years ago (2015-12-07 17:38:22 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-07 17:53:36 UTC) #8
herb_g
I have added some calls to the constructors that cause the code generation to work ...
5 years ago (2015-12-07 18:39:24 UTC) #11
bungeman-skia
I think I believe in this. It seems disappointing that we're doing this on all ...
5 years ago (2015-12-07 18:51:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507633004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507633004/80001
5 years ago (2015-12-07 20:11:56 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-07 20:12:32 UTC) #17
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/d4c24f67496ff2e5e83bc7ce7945cbb85484bfa6

Powered by Google App Engine
This is Rietveld 408576698