Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1507623003: Clarify error messages in roll_dep.py (Closed)

Created:
5 years ago by brucedawson
Modified:
5 years ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Clarify error messages in roll_dep.py If you specify a directory incorrectly to roll_dep then it may not be obvious why it cannot be found. For instance, "roll-dep tools\gyp" vs. "roll-dep src\tools\gyp". This change prints the full directory. This change also clarifies what is meant by a clean tree to make that error message easier to understand. R=maruel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297875

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M roll_dep.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
brucedawson
While using roll-dep I got confused by both of these error messages. This change tweaks ...
5 years ago (2015-12-07 21:04:05 UTC) #1
M-A Ruel
lgtm Good idea.
5 years ago (2015-12-07 21:15:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507623003/1
5 years ago (2015-12-07 21:15:57 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-07 21:46:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297875

Powered by Google App Engine
This is Rietveld 408576698