Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1507623002: Add an --expose-wasm flag. (Closed)

Created:
5 years ago by titzer
Modified:
5 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add an --expose-wasm flag. This adds a runtime flag that controls whether the WASM object is exposed to JavaScript. While currently guarded by the V8_WASM build-time flag, after landing in V8 the build-time flag will be removed, leaving only this new runtime flag. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/a29f81f603c05e080b54f8e1330575362c6579d5 Cr-Commit-Position: refs/heads/master@{#32657}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/bootstrapper.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
5 years ago (2015-12-07 13:04:51 UTC) #1
Michael Starzinger
LGTM.
5 years ago (2015-12-07 13:16:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507623002/1
5 years ago (2015-12-07 13:24:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 13:39:19 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-07 13:40:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a29f81f603c05e080b54f8e1330575362c6579d5
Cr-Commit-Position: refs/heads/master@{#32657}

Powered by Google App Engine
This is Rietveld 408576698