Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1507613002: Split SVGStringList related measurements from SVG1DOM counter (Closed)

Created:
5 years ago by davve
Modified:
5 years ago
CC:
chromium-reviews, krit, kouhei+svg_chromium.org, fs, f(malita), asvitkine+watch_chromium.org, blink-reviews, gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split SVGStringList related measurements from SVG1DOM counter Measure users of SVGStringList individually to see if the SVGStringList and SVGTests interfaces can be removed or needs to stay. BUG=415074 Committed: https://crrev.com/2c9be589e5244cedb5c85f09004e88ae3ad8a29c Cr-Commit-Position: refs/heads/master@{#364074}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Split into two counters #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTests.idl View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGViewElement.idl View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 36 (18 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507613002/1
5 years ago (2015-12-07 10:43:27 UTC) #2
davve
These are all users of SVGStringList I can find. I used Measure first, but that ...
5 years ago (2015-12-07 10:46:05 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/132006) ios_rel_device_ninja on ...
5 years ago (2015-12-07 10:46:21 UTC) #6
davve
+isherman for histograms.xml
5 years ago (2015-12-07 10:52:34 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507613002/20001
5 years ago (2015-12-07 10:52:59 UTC) #10
philipj_slow
Discussed IRL. LGTM with viewTarget measured separately, just in case that's used more than the ...
5 years ago (2015-12-07 10:57:25 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507613002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507613002/40001
5 years ago (2015-12-07 11:10:20 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-07 12:29:32 UTC) #15
Ilya Sherman
histograms.xml lgtm
5 years ago (2015-12-07 20:12:42 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507613002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507613002/40001
5 years ago (2015-12-07 21:13:54 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/126044)
5 years ago (2015-12-07 21:55:19 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507613002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507613002/60001
5 years ago (2015-12-08 08:05:09 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/89066) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years ago (2015-12-08 08:29:44 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507613002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507613002/60001
5 years ago (2015-12-08 10:58:38 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/139665)
5 years ago (2015-12-08 11:33:09 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507613002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507613002/80001
5 years ago (2015-12-09 14:17:28 UTC) #33
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years ago (2015-12-09 16:14:18 UTC) #34
commit-bot: I haz the power
5 years ago (2015-12-09 16:15:24 UTC) #36
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/2c9be589e5244cedb5c85f09004e88ae3ad8a29c
Cr-Commit-Position: refs/heads/master@{#364074}

Powered by Google App Engine
This is Rietveld 408576698