Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1507613002:
Split SVGStringList related measurements from SVG1DOM counter (Closed)
|
Created:
5 years ago by davve Modified:
5 years ago CC:
chromium-reviews, krit, kouhei+svg_chromium.org, fs, f(malita), asvitkine+watch_chromium.org, blink-reviews, gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSplit SVGStringList related measurements from SVG1DOM counter
Measure users of SVGStringList individually to see if the
SVGStringList and SVGTests interfaces can be removed or needs to stay.
BUG=415074
Committed: https://crrev.com/2c9be589e5244cedb5c85f09004e88ae3ad8a29c
Cr-Commit-Position: refs/heads/master@{#364074}
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Split into two counters #Patch Set 4 : Rebase #Patch Set 5 : Rebase #
Messages
Total messages: 36 (18 generated)
The CQ bit was checked by davve@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507613002/1
davve@opera.com changed reviewers: + fs@opera.com, philipj@opera.com
These are all users of SVGStringList I can find. I used Measure first, but that expanded into 16 different counters. Seemed a bit overkill, so I made another SVG1DOM* bucket. I also noted that SVGStringList was one of few list interfaces that didn't have an ineffective MeasureAs attribute. Not sure if that was intentional or not.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by davve@opera.com to run a CQ dry run
davve@opera.com changed reviewers: + isherman@chromium.org
+isherman for histograms.xml
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507613002/20001
Discussed IRL. LGTM with viewTarget measured separately, just in case that's used more than the rest, in which case it would still be nice to get rid of the crufty SVGTests interface.
The CQ bit was checked by davve@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507613002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507613002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
histograms.xml lgtm
The CQ bit was checked by davve@opera.com
The patchset sent to the CQ was uploaded after l-g-t-m from philipj@opera.com Link to the patchset: https://codereview.chromium.org/1507613002/#ps40001 (title: "Split into two counters")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507613002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507613002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by davve@opera.com
The patchset sent to the CQ was uploaded after l-g-t-m from philipj@opera.com, isherman@chromium.org Link to the patchset: https://codereview.chromium.org/1507613002/#ps60001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507613002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507613002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by davve@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507613002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507613002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by davve@opera.com
The patchset sent to the CQ was uploaded after l-g-t-m from philipj@opera.com, isherman@chromium.org Link to the patchset: https://codereview.chromium.org/1507613002/#ps80001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507613002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507613002/80001
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Split SVGStringList related measurements from SVG1DOM counter Measure users of SVGStringList individually to see if the SVGStringList and SVGTests interfaces can be removed or needs to stay. BUG=415074 ========== to ========== Split SVGStringList related measurements from SVG1DOM counter Measure users of SVGStringList individually to see if the SVGStringList and SVGTests interfaces can be removed or needs to stay. BUG=415074 Committed: https://crrev.com/2c9be589e5244cedb5c85f09004e88ae3ad8a29c Cr-Commit-Position: refs/heads/master@{#364074} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/2c9be589e5244cedb5c85f09004e88ae3ad8a29c Cr-Commit-Position: refs/heads/master@{#364074} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
