Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: Source/bindings/tests/results/V8TestEventTarget.cpp

Issue 15076011: Support union return type for anonymous named/indexed getter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestEventTarget.cpp
diff --git a/Source/bindings/tests/results/V8TestEventTarget.cpp b/Source/bindings/tests/results/V8TestEventTarget.cpp
index cbb734e1d6cd0a51ce87cd7630fcc3a05d6b43a1..eed95dad92b78a10fbaae1e8e0167d3a47089897 100644
--- a/Source/bindings/tests/results/V8TestEventTarget.cpp
+++ b/Source/bindings/tests/results/V8TestEventTarget.cpp
@@ -199,7 +199,10 @@ v8::Handle<v8::Value> V8TestEventTarget::indexedPropertyGetter(uint32_t index, c
RefPtr<Node> element = collection->item(index);
if (!element)
return v8Undefined();
- return toV8Fast(element.release(), info, collection);
+
+ v8::Handle<v8::Value> jsValue;
+ jsValue = toV8Fast(element.release(), info, collection);
+ return jsValue;
}
v8::Handle<v8::Value> V8TestEventTarget::namedPropertyGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
@@ -215,7 +218,10 @@ v8::Handle<v8::Value> V8TestEventTarget::namedPropertyGetter(v8::Local<v8::Strin
RefPtr<Node> element = collection->namedItem(propertyName);
if (!element)
return v8Undefined();
- return toV8Fast(element.release(), info, collection);
+
+ v8::Handle<v8::Value> jsValue;
+ jsValue = toV8Fast(element.release(), info, collection);
+ return jsValue;
}
static v8::Persistent<v8::FunctionTemplate> ConfigureV8TestEventTargetTemplate(v8::Persistent<v8::FunctionTemplate> desc, v8::Isolate* isolate, WrapperWorldType currentWorldType)

Powered by Google App Engine
This is Rietveld 408576698