Support union return type for anonymous named/indexed getter

Source/bindings/tests/results/V8TestObject.cpp

 /*
     This file is part of the Blink open source project.
     This file has been auto-generated by CodeGeneratorV8.pm. DO NOT MODIFY!
 
     This library is free software; you can redistribute it and/or
     modify it under the terms of the GNU Library General Public
     License as published by the Free Software Foundation; either
     version 2 of the License, or (at your option) any later version.
 
     This library is distributed in the hope that it will be useful,
@@ skipping 10 matching lines @@
 #include "config.h"
 #include "V8TestObject.h"
 
 #include "HTMLNames.h"
 #include "RuntimeEnabledFeatures.h"
 #include "ScriptProfile.h"
 #include "V8DOMStringList.h"
 #include "V8Document.h"
 #include "V8Float32Array.h"
 #include "V8Node.h"
+#include "V8NodeList.h"
 #include "V8SVGDocument.h"
 #include "V8SVGPoint.h"
 #include "V8ScriptProfile.h"
 #include "V8TestCallback.h"
 #include "V8TestNode.h"
 #include "V8TestSubObj.h"
 #include "bindings/v8/BindingSecurity.h"
 #include "bindings/v8/Dictionary.h"
 #include "bindings/v8/ScriptController.h"
 #include "bindings/v8/ScriptValue.h"
@@ skipping 4253 matching lines @@
     if (ConstructorMode::current() == ConstructorMode::WrapExistingObject)
         return args.Holder();
 
     return TestObjV8Internal::constructor(args);
 }
 
 v8::Handle<v8::Value> V8TestObject::indexedPropertyGetter(uint32_t index, const v8::AccessorInfo& info)
 {
     ASSERT(V8DOMWrapper::maybeDOMWrapper(info.Holder()));
     TestObj* collection = toNative(info.Holder());
-    RefPtr<Node> element = collection->item(index);
-    if (!element)
+    WTF::UnionType2<NodeList, Node> element = collection->item(index);
+    if (element.isNull())
         return v8Undefined();
-    return toV8Fast(element.release(), info, collection);
+
+    v8::Handle<v8::Value> jsValue;
+    if (element.isValue0Enabled())
+        jsValue = toV8Fast(element.getValue0(), info, collection);
+    if (element.isValue1Enabled())
+        jsValue = toV8Fast(element.getValue1(), info, collection);
+
+    return jsValue;

[haraken, 2013/05/15 10:56:25]

Can we write this like:

  return toV8Fast(element.enabledValue(), info, collection);

?

 }
 
 v8::Handle<v8::Value> V8TestObject::namedPropertyGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
 {
     if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())
         return v8Undefined();
     if (info.Holder()->HasRealNamedCallbackProperty(name))
         return v8Undefined();
 
     ASSERT(V8DOMWrapper::maybeDOMWrapper(info.Holder()));
     TestObj* collection = toNative(info.Holder());
     AtomicString propertyName = toWebCoreAtomicString(name);
     String element = collection->namedItem(propertyName);
     if (element.isNull())
         return v8Undefined();
-    return v8String(element, info.GetIsolate());
+
+    v8::Handle<v8::Value> jsValue;
+    jsValue = v8String(element, info.GetIsolate());
+    return jsValue;

[haraken, 2013/05/15 10:56:25]

Nit: We might not want to introduce the jsValue indirection (just for
readability).

 }
 
 static v8::Persistent<v8::FunctionTemplate> ConfigureV8TestObjectTemplate(v8::Persistent<v8::FunctionTemplate> desc, v8::Isolate* isolate, WrapperWorldType currentWorldType)
 {
     desc->ReadOnlyPrototype();
 
     v8::Local<v8::Signature> defaultSignature;
     defaultSignature = V8DOMConfiguration::configureTemplate(desc, "TestObject", v8::Persistent<v8::FunctionTemplate>(), V8TestObject::internalFieldCount,
         V8TestObjectAttrs, WTF_ARRAY_LENGTH(V8TestObjectAttrs),
         V8TestObjectMethods, WTF_ARRAY_LENGTH(V8TestObjectMethods), isolate, currentWorldType);
@@ skipping 171 matching lines @@
     installPerContextProperties(wrapper, impl.get(), isolate);
     V8DOMWrapper::associateObjectWithWrapper(impl, &info, wrapper, isolate, hasDependentLifetime ? WrapperConfiguration::Dependent : WrapperConfiguration::Independent);
     return wrapper;
 }
 void V8TestObject::derefObject(void* object)
 {
     static_cast<TestObj*>(object)->deref();
 }
 
 } // namespace WebCore