pkg/analysis_server/test/services/completion/completion_test_util.dart - Issue 1507513002: extract field formal contributor from prefixed element contributor

Unified Diff: pkg/analysis_server/test/services/completion/completion_test_util.dart

Issue 1507513002: extract field formal contributor from prefixed element contributor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: merge Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart ('k') | pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/completion/completion_test_util.dart

diff --git a/pkg/analysis_server/test/services/completion/completion_test_util.dart b/pkg/analysis_server/test/services/completion/completion_test_util.dart

index 29108cac52486b123dc8245d83e95340db0d3e48..63180b7b4b2ef289437c959bbc064a6d66608d03 100644

--- a/pkg/analysis_server/test/services/completion/completion_test_util.dart

+++ b/pkg/analysis_server/test/services/completion/completion_test_util.dart

@@ -4418,10 +4418,9 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {

return computeFull((bool result) {

expect(request.replacementOffset, completionOffset);

expect(request.replacementLength, 0);

- assertSuggestInvocationField('b', null,

- relevance: DART_RELEVANCE_LOCAL_FIELD);

- assertSuggestInvocationField('_c', 'X',

- relevance: DART_RELEVANCE_LOCAL_FIELD);

+ // Contributed by FieldFormalConstructorContributor

+ assertNotSuggested('b');

+ assertNotSuggested('_c');

assertNotSuggested('sb');

assertNotSuggested('d');

assertNotSuggested('_e');

@@ -4458,10 +4457,9 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {

return computeFull((bool result) {

expect(request.replacementOffset, completionOffset - 1);

expect(request.replacementLength, 1);

- assertSuggestInvocationField('b', null,

- relevance: DART_RELEVANCE_LOCAL_FIELD);

- assertSuggestInvocationField('_c', 'X',

- relevance: DART_RELEVANCE_LOCAL_FIELD);

+ // Contributed by FieldFormalConstructorContributor

+ assertNotSuggested('b');

+ assertNotSuggested('_c');

assertNotSuggested('d');

assertNotSuggested('_e');

assertNotSuggested('f');

@@ -4497,10 +4495,9 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {

return computeFull((bool result) {

expect(request.replacementOffset, completionOffset);

expect(request.replacementLength, 1);

- assertSuggestInvocationField('b', null,

- relevance: DART_RELEVANCE_LOCAL_FIELD);

- assertSuggestInvocationField('_c', 'X',

- relevance: DART_RELEVANCE_LOCAL_FIELD);

+ // Contributed by FieldFormalConstructorContributor

+ assertNotSuggested('b');

+ assertNotSuggested('_c');

assertNotSuggested('d');

assertNotSuggested('_e');

assertNotSuggested('f');

@@ -4537,8 +4534,8 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {

expect(request.replacementOffset, completionOffset);

expect(request.replacementLength, 0);

assertNotSuggested('b');

- assertSuggestInvocationField('_c', 'X',

- relevance: DART_RELEVANCE_LOCAL_FIELD);

+ // Contributed by FieldFormalConstructorContributor

+ assertNotSuggested('_c');

assertNotSuggested('d');

assertNotSuggested('_e');

assertNotSuggested('f');