extract field formal contributor from prefixed element contributor

pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.contributor.dart.invocation;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
 import 'package:analysis_server/src/services/completion/local_declaration_visitor.dart';
@@ skipping 78 matching lines @@
       }
       InterfaceTypeSuggestionBuilder.suggestionsFor(request, node.bestType,
           isSuper: isSuper, containingMethodName: containingMethodName);
       return new Future.value(true);
     }
     return new Future.value(false);
   }
 }
 
 /**
- * A suggestion builder for 'this.' constructor arguments.
- */
-class _FieldFormalSuggestionBuilder implements SuggestionBuilder {
-  final DartCompletionRequest request;
-
-  _FieldFormalSuggestionBuilder(this.request);
-
-  @override
-  bool computeFast(AstNode node) {
-    if (node is FieldFormalParameter) {
-      ConstructorDeclaration constructorDecl =
-          node.getAncestor((p) => p is ConstructorDeclaration);
-      if (constructorDecl != null) {
-        // Compute fields already referenced
-        List<String> referencedFields = new List<String>();
-        for (FormalParameter param in constructorDecl.parameters.parameters) {
-          if (param is FieldFormalParameter) {
-            SimpleIdentifier fieldId = param.identifier;
-            if (fieldId != null && fieldId != request.target.entity) {
-              String fieldName = fieldId.name;
-              if (fieldName != null && fieldName.length > 0) {
-                referencedFields.add(fieldName);
-              }
-            }
-          }
-        }
-
-        // Add suggestions for fields that are not already referenced
-        ClassDeclaration classDecl =
-            constructorDecl.getAncestor((p) => p is ClassDeclaration);
-        for (ClassMember member in classDecl.members) {
-          if (member is FieldDeclaration && !member.isStatic) {
-            for (VariableDeclaration varDecl in member.fields.variables) {
-              SimpleIdentifier fieldId = varDecl.name;
-              if (fieldId != null) {
-                String fieldName = fieldId.name;
-                if (fieldName != null && fieldName.length > 0) {
-                  if (!referencedFields.contains(fieldName)) {
-                    CompletionSuggestion suggestion =
-                        createFieldSuggestion(request.source, member, varDecl);
-                    if (suggestion != null) {
-                      request.addSuggestion(suggestion);
-                    }
-                  }
-                }
-              }
-            }
-          }
-        }
-      }
-    } else {
-      // This should never be called with a case not handled above.
-      assert(false);
-    }
-    return true;
-  }
-
-  @override
-  Future<bool> computeFull(AstNode node) {
-    // This should never be called; we should always be able to compute
-    // suggestions and return true in computeFast method.
-    assert(false);
-    return null;
-  }
-}
-
-/**
  * An [AstNode] vistor for determining which suggestion builder
  * should be used to build invocation/access suggestions.
  */
 class _InvocationAstVisitor extends GeneralizingAstVisitor<SuggestionBuilder> {
   final DartCompletionRequest request;
 
   _InvocationAstVisitor(this.request);
 
   @override
   SuggestionBuilder visitConstructorName(ConstructorName node) {
     // some PrefixedIdentifier nodes are transformed into
     // ConstructorName nodes during the resolution process.
     return new _PrefixedIdentifierSuggestionBuilder(request);
   }
 
   @override
-  SuggestionBuilder visitFieldFormalParameter(FieldFormalParameter node) {
-    return new _FieldFormalSuggestionBuilder(request);
-  }
-
-  @override
   SuggestionBuilder visitMethodInvocation(MethodInvocation node) {
     return new _ExpressionSuggestionBuilder(request);
   }
 
   @override
   SuggestionBuilder visitNode(AstNode node) {
     return null;
   }
 
   @override
@@ skipping 236 matching lines @@
     }
     return new Future.value(false);
   }
 
   @override
   Future<bool> visitVariableElement(VariableElement element) {
     InterfaceTypeSuggestionBuilder.suggestionsFor(request, element.type);
     return new Future.value(true);
   }
 }