Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1507483002: Simplify prefinalizer processing. (Closed)

Created:
5 years ago by sof
Modified:
5 years ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify prefinalizer processing. The processing can be performed in one pass. R=haraken BUG=420515 NOTRY=true Committed: https://crrev.com/6f37a1b43a57f5e19aa8f7915b914f7cd8a800fa Cr-Commit-Position: refs/heads/master@{#363426}

Patch Set 1 #

Patch Set 2 : rephrase w/ do-while #

Patch Set 3 : tidying #

Patch Set 4 : final tidying #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -19 lines) Patch
M third_party/WebKit/Source/platform/heap/Heap.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 2 3 1 chunk +23 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/TraceTraits.h View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
sof
please take a look.
5 years ago (2015-12-06 07:48:25 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507483002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507483002/80001
5 years ago (2015-12-06 07:48:51 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/151014)
5 years ago (2015-12-06 09:38:58 UTC) #8
haraken
LGTM
5 years ago (2015-12-06 23:13:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507483002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507483002/80001
5 years ago (2015-12-07 06:19:14 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/151203)
5 years ago (2015-12-07 08:15:51 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507483002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507483002/80001
5 years ago (2015-12-07 08:43:47 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years ago (2015-12-07 08:48:25 UTC) #19
commit-bot: I haz the power
5 years ago (2015-12-07 08:49:21 UTC) #21
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/6f37a1b43a57f5e19aa8f7915b914f7cd8a800fa
Cr-Commit-Position: refs/heads/master@{#363426}

Powered by Google App Engine
This is Rietveld 408576698