clang/win: Let some chromium_code targets build with -Wextra.

content/browser/gamepad/raw_input_data_fetcher_win.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/gamepad/raw_input_data_fetcher_win.h"
 
 #include "base/trace_event/trace_event.h"
 #include "content/common/gamepad_hardware_buffer.h"
 #include "content/common/gamepad_messages.h"
 
@@ skipping 40 matching lines @@
   ClearControllers();
   DCHECK(!window_);
   DCHECK(!events_monitored_);
 }
 
 void RawInputDataFetcher::WillDestroyCurrentMessageLoop() {
   StopMonitor();
 }
 
 RAWINPUTDEVICE* RawInputDataFetcher::GetRawInputDevices(DWORD flags) {
-  int usage_count = arraysize(DeviceUsages);
+  size_t usage_count = arraysize(DeviceUsages);
   scoped_ptr<RAWINPUTDEVICE[]> devices(new RAWINPUTDEVICE[usage_count]);
-  for (int i = 0; i < usage_count; ++i) {
+  for (size_t i = 0; i < usage_count; ++i) {
     devices[i].dwFlags = flags;
     devices[i].usUsagePage = 1;
     devices[i].usUsage = DeviceUsages[i];
     devices[i].hwndTarget = (flags & RIDEV_REMOVE) ? 0 : window_->hwnd();
   }
   return devices.release();
 }
 
 void RawInputDataFetcher::StartMonitor() {
   if (!rawinput_available_ || events_monitored_)
@@ skipping 119 matching lines @@
   result = GetRawInputDeviceInfo(hDevice, RIDI_DEVICEINFO,
       di_buffer.get(), &size);
   if (result == static_cast<UINT>(-1)) {
     PLOG(ERROR) << "GetRawInputDeviceInfo() failed";
     return NULL;
   }
   DCHECK_EQ(size, result);
 
   // Make sure this device is of a type that we want to observe.
   bool valid_type = false;
-  for (int i = 0; i < arraysize(DeviceUsages); ++i) {
-    if (device_info->hid.usUsage == DeviceUsages[i]) {
+  for (USHORT device_usage : DeviceUsages) {
+    if (device_info->hid.usUsage == device_usage) {
       valid_type = true;
       break;
     }
   }
 
   if (!valid_type)
     return NULL;
 
   scoped_ptr<RawGamepadInfo> gamepad_info(new RawGamepadInfo);
   gamepad_info->handle = hDevice;
@@ skipping 167 matching lines @@
                             &buttons_length,
                             gamepad_info->preparsed_data,
                             reinterpret_cast<PCHAR>(input->data.hid.bRawData),
                             input->data.hid.dwSizeHid);
 
     if (status == HIDP_STATUS_SUCCESS) {
       // Set each reported button to true.
       for (uint32_t j = 0; j < buttons_length; j++) {
         int32_t button_index = usages[j].Usage - 1;
         if (button_index >= 0 &&
-            button_index < blink::WebGamepad::buttonsLengthCap)
+            button_index <
+                static_cast<int>(blink::WebGamepad::buttonsLengthCap)) {
           gamepad_info->buttons[button_index] = true;
+        }
       }
     }
   }
 
   // Query axis state.
   ULONG axis_value = 0;
   LONG scaled_axis_value = 0;
   for (uint32_t i = 0; i < gamepad_info->axes_length; i++) {
     RawGamepadAxis* axis = &gamepad_info->axes[i];
 
@@ skipping 107 matching lines @@
     return false;
   hidd_get_product_string_ = reinterpret_cast<HidDGetStringFunc>(
       hid_dll_.GetFunctionPointer("HidD_GetProductString"));
   if (!hidd_get_product_string_)
     return false;
 
   return true;
 }
 
 }  // namespace content