Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 15074005: Cleaned up Crankshaft pipeline a bit. (Closed)

Created:
7 years, 7 months ago by Sven Panne
Modified:
7 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Cleaned up Crankshaft pipeline a bit. Two tiny changes: * Some phases were missing an HPhase, which was added, so we can now see all phases in the visualizer output. * Consistently test commandline flags directly in the pipeline, making it clearer which parts are optional and which are not. R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14615

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -19 lines) Patch
M src/hydrogen.cc View 7 chunks +18 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
7 years, 7 months ago (2013-05-10 11:24:58 UTC) #1
Michael Starzinger
LGTM.
7 years, 7 months ago (2013-05-10 11:31:40 UTC) #2
Sven Panne
7 years, 7 months ago (2013-05-10 11:32:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14615 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698