Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 1507373004: Use a pseudo-extension CHROMIUM_framebuffer_mixed_samples (Closed)

Created:
5 years ago by Kimmo Kinnunen
Modified:
5 years ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use a pseudo-extension CHROMIUM_framebuffer_mixed_samples Use the pseudo-extension CHROMIUM_framebuffer_mixed_samples when run with Chromium command buffer. The extension exposes NV_framebuffer_mixed_samples subset that Skia needs in order to use NV_path_rendering with mixed samples. BUG=506765 Committed: https://skia.googlesource.com/skia/+/ea40943f8e71dd515d5d64471a6d0f67abc6dc12

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M src/gpu/gl/GrGLAssembleInterface.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Kimmo Kinnunen
5 years ago (2015-12-09 12:31:35 UTC) #2
bsalomon
lgtm
5 years ago (2015-12-09 14:03:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507373004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507373004/20001
5 years ago (2015-12-10 09:06:02 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-10 09:22:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ea40943f8e71dd515d5d64471a6d0f67abc6dc12

Powered by Google App Engine
This is Rietveld 408576698