Clean up attributes of image elements

java/org/chromium/distiller/webdocument/WebImage.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.distiller.webdocument;
 
 import com.google.gwt.dom.client.Document;
 import com.google.gwt.dom.client.Element;
 import com.google.gwt.dom.client.ImageElement;
 
@@ skipping 27 matching lines @@
         if (srcUrl == null) {
             srcUrl = "";
         }
     }
 
     @Override
     public String generateOutput(boolean textOnly) {
         if (textOnly) return "";
         Element container = Document.get().createDivElement();
         ImageElement ie = ImageElement.as(Element.as(imgElement.cloneNode(false)));
+        ie.setSrc(ie.getSrc());

[mdjones, 2015/12/09 17:40:16]

Instead of removing all the attributes manually, wouldn't it be easier to simply
create a new image element and set the attributes we actually want?  I believe
this is just src and srcset. This would replace cloning the element.

[wychen, 2015/12/09 22:27:53]

Done.

         DomUtil.makeSrcSetAbsolute(ie);
         container.appendChild(ie);
+
+        DomUtil.stripIds(ie);
+        DomUtil.stripStyleAttributes(ie);
+        DomUtil.stripAlignAttributes(ie);
+
         return container.getInnerHTML();
     }
 
     /**
      * Get the image element of this WebImage.
      * @return Image element or null.
      */
     public Element getImageNode() {
         return imgElement;
     }
@@ skipping 15 matching lines @@
     }
 
     /**
      * Get the source URL of this image.
      * @return Source URL or an empty string.
      */
     public String getSrc() {
         return srcUrl;
     }
 }