Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1507363002: MIPS: Fix NaN tests. (Closed)

Created:
5 years ago by balazs.kilvady
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix NaN tests. BUG= TEST=mjsunit/regress/regress-undefined-nan, mjsunit/regress/regress-undefined-nan3, mjsunit/regress/regress-2596 Committed: https://crrev.com/9597b019bc7a9ab4687801c20828dbe4b36f93a3 Cr-Commit-Position: refs/heads/master@{#32741}

Patch Set 1 #

Patch Set 2 : Fix regress-2596 test. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -8 lines) Patch
M src/runtime/runtime.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/runtime/runtime-numbers.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-2596.js View 1 1 chunk +5 lines, -3 lines 0 comments Download
M test/mjsunit/regress/regress-undefined-nan.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-undefined-nan3.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507363002/1
5 years ago (2015-12-08 20:47:26 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/12886)
5 years ago (2015-12-08 21:01:04 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507363002/20001
5 years ago (2015-12-09 10:44:18 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/11209)
5 years ago (2015-12-09 10:58:50 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507363002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507363002/40001
5 years ago (2015-12-09 12:52:39 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-09 13:15:34 UTC) #14
paul.l...
LGTM. Benedikt, could you PTAL?
5 years ago (2015-12-10 05:59:03 UTC) #16
Benedikt Meurer
LGTM.
5 years ago (2015-12-10 09:05:03 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507363002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507363002/40001
5 years ago (2015-12-10 10:04:38 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-10 10:05:52 UTC) #21
commit-bot: I haz the power
5 years ago (2015-12-10 10:06:25 UTC) #23
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/9597b019bc7a9ab4687801c20828dbe4b36f93a3
Cr-Commit-Position: refs/heads/master@{#32741}

Powered by Google App Engine
This is Rietveld 408576698