Issue 1507353003: Remove informational message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1507353003: Remove informational message (Closed)

Created:
5 years ago by Brian Wilkerson

Modified:
5 years ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Remove informational message R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/9b474c4fdee816c4a535cd4788717e557d5e3e90

Patch Set 1 #

Total comments: 1

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -8 lines)			Patch
	M	pkg/analyzer/lib/src/generated/source.dart	View		2 chunks	+7 lines, -8 lines	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

https://codereview.chromium.org/1507353003/diff/1/pkg/analyzer/lib/src/generated/source.dart File pkg/analyzer/lib/src/generated/source.dart (right): https://codereview.chromium.org/1507353003/diff/1/pkg/analyzer/lib/src/generated/source.dart#newcode761 pkg/analyzer/lib/src/generated/source.dart:761: AnalysisEngine.instance.logger.logInformation( The other option would be to never log ...

5 years ago (2015-12-08 19:37:13 UTC) #2

Brian Wilkerson

5 years ago (2015-12-08 19:39:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9b474c4fdee816c4a535cd4788717e557d5e3e90 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages