Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1507333002: Add a content_shell flag to turn on partial site isolation. (Closed)

Created:
5 years ago by ncarter (slow)
Modified:
5 years ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Peter Beverloo, jam, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a content_shell flag to turn on partial site isolation. This will let us write a test for bug 567424. BUG=567424 Committed: https://crrev.com/d410644c8410aa448eaed7d6845a22dcf8a1aa80 Cr-Commit-Position: refs/heads/master@{#363801}

Patch Set 1 #

Patch Set 2 : Self-review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M content/shell/browser/shell_content_browser_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 1 4 chunks +22 lines, -0 lines 0 comments Download
M content/shell/common/shell_content_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/common/shell_content_client.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/shell/common/shell_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/common/shell_switches.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Charlie Reis
Thanks! LGTM.
5 years ago (2015-12-08 18:56:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507333002/20001
5 years ago (2015-12-08 18:57:55 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/152003)
5 years ago (2015-12-08 19:12:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507333002/20001
5 years ago (2015-12-08 19:56:07 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-08 21:53:18 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-08 21:54:44 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d410644c8410aa448eaed7d6845a22dcf8a1aa80
Cr-Commit-Position: refs/heads/master@{#363801}

Powered by Google App Engine
This is Rietveld 408576698