Source/core/frame/FrameView.cpp - Issue 150733002: Place inner frame scrollbars on the left side, if indicated by the frame-level text direction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/FrameView.cpp

Issue 150733002: Place inner frame scrollbars on the left side, if indicated by the frame-level text direction. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@issue_312435

Patch Set: Place inner frame scrollbars on the left side, if indicated by the frame-level text direction. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/FrameView.cpp

diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp

index 99b2e7368871438fa3af58c19e8cf1e0cb84e63c..17041fc15f470a3c75a122e5754d82725f3d47f2 100644

--- a/Source/core/frame/FrameView.cpp

+++ b/Source/core/frame/FrameView.cpp

@@ -1383,6 +1383,24 @@ void FrameView::viewportConstrainedVisibleContentSizeChanged(bool widthChanged,

}

+bool FrameView::shouldPlaceVerticalScrollbarOnLeft() const

+ // FIXME: Mainframe scrollbar placement should respect the embedding application RTL UI policy.

+ // See crbug.com/249860.

+ if (isMainFrame())

+ return false;

+ Document* document = m_frame->document();

+ if (!document)

+ return false;

+ if (!document->body() || !document->body()->renderer())

Julien - ping for review 2014/03/12 23:19:10 I would put a comment that 'direction' is inherite

+ return false;

+ // Use the <body> text direction to dictate the frame scrollbar placement.

+ return document->body()->renderer()->style()->shouldPlaceBlockDirectionScrollbarOnLogicalLeft();

Julien - ping for review 2014/03/12 23:19:10 shouldPlaceBlockDirectionScrollbarOnLogicalLeft is

IntSize FrameView::scrollOffsetForFixedPosition() const

{

return toIntSize(clampScrollPosition(scrollPosition()));

« no previous file with comments | « Source/core/frame/FrameView.h ('k') | no next file » | no next file with comments »