Chromium Code Reviews Chromium Code Reviews
Issue 150733002:
Place inner frame scrollbars on the left side, if indicated by the frame-level text direction. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@issue_312435| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> | 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> |
| 3 * 1999 Lars Knoll <knoll@kde.org> | 3 * 1999 Lars Knoll <knoll@kde.org> |
| 4 * 1999 Antti Koivisto <koivisto@kde.org> | 4 * 1999 Antti Koivisto <koivisto@kde.org> |
| 5 * 2000 Dirk Mueller <mueller@kde.org> | 5 * 2000 Dirk Mueller <mueller@kde.org> |
| 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. | 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. |
| 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) | 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) |
| 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) | 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) |
| 9 * Copyright (C) 2009 Google Inc. All rights reserved. | 9 * Copyright (C) 2009 Google Inc. All rights reserved. |
| 10 * | 10 * |
| (...skipping 1311 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1322 } | 1322 } |
| 1323 | 1323 |
| 1324 LayoutRect FrameView::viewportConstrainedVisibleContentRect() const | 1324 LayoutRect FrameView::viewportConstrainedVisibleContentRect() const |
| 1325 { | 1325 { |
| 1326 LayoutRect viewportRect = visibleContentRect(); | 1326 LayoutRect viewportRect = visibleContentRect(); |
| 1327 // Ignore overhang. No-op when not using rubber banding. | 1327 // Ignore overhang. No-op when not using rubber banding. |
| 1328 viewportRect.setLocation(clampScrollPosition(scrollPosition())); | 1328 viewportRect.setLocation(clampScrollPosition(scrollPosition())); |
| 1329 return viewportRect; | 1329 return viewportRect; |
| 1330 } | 1330 } |
| 1331 | 1331 |
| 1332 bool FrameView::shouldPlaceVerticalScrollbarOnLeft() const | |
| 1333 { | |
| 1334 // Mainframe scrollbar placement should respect the embedding application RT L UI policy. | |
|
Julien - ping for review
2014/02/12 23:25:49
That looks like a FIXME related to crbug.com/24986
| |
| 1335 if (isMainFrame()) | |
| 1336 return false; | |
| 1337 | |
| 1338 Document* document = m_frame->document(); | |
| 1339 if (!document) | |
| 1340 return false; | |
| 1341 | |
| 1342 if (!document->body() || !document->body()->renderer()) | |
| 1343 return false; | |
| 1344 | |
| 1345 // Use the <body> text direction to dictate the frame scrollbar placement. | |
| 1346 return document->body()->renderer()->style()->shouldPlaceBlockDirectionScrol lbarOnLogicalLeft(); | |
| 1347 } | |
| 1332 | 1348 |
| 1333 IntSize FrameView::scrollOffsetForFixedPosition() const | 1349 IntSize FrameView::scrollOffsetForFixedPosition() const |
| 1334 { | 1350 { |
| 1335 return toIntSize(clampScrollPosition(scrollPosition())); | 1351 return toIntSize(clampScrollPosition(scrollPosition())); |
| 1336 } | 1352 } |
| 1337 | 1353 |
| 1338 IntPoint FrameView::lastKnownMousePosition() const | 1354 IntPoint FrameView::lastKnownMousePosition() const |
| 1339 { | 1355 { |
| 1340 return m_frame->eventHandler().lastKnownMousePosition(); | 1356 return m_frame->eventHandler().lastKnownMousePosition(); |
| 1341 } | 1357 } |
| (...skipping 1821 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 3163 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation) | 3179 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation) |
| 3164 { | 3180 { |
| 3165 ScrollableArea::willRemoveScrollbar(scrollbar, orientation); | 3181 ScrollableArea::willRemoveScrollbar(scrollbar, orientation); |
| 3166 if (AXObjectCache* cache = axObjectCache()) { | 3182 if (AXObjectCache* cache = axObjectCache()) { |
| 3167 cache->remove(scrollbar); | 3183 cache->remove(scrollbar); |
| 3168 cache->handleScrollbarUpdate(this); | 3184 cache->handleScrollbarUpdate(this); |
| 3169 } | 3185 } |
| 3170 } | 3186 } |
| 3171 | 3187 |
| 3172 } // namespace WebCore | 3188 } // namespace WebCore |
| OLD | NEW |
